portable: Retain the provided type IDs (#174)

* ty: Make type fields public Signed-off-by: Alexandru Vasile <[email protected]> * portable: Add recursive type ID resolver Signed-off-by: Alexandru Vasile <[email protected]> * tests: Check recursive type ID correctness Signed-off-by: Alexandru Vasile <[email protected]> * portable: Implement `retain` on the `PortableRegistry` Signed-off-by: Alexandru Vasile <[email protected]> * tests: Check `retain` method Signed-off-by: Alexandru Vasile <[email protected]> * portable: Add error type Signed-off-by: Alexandru Vasile <[email protected]> * derive: Fix clippy and improve documentation Signed-off-by: Alexandru Vasile <[email protected]> * Fix clippy Signed-off-by: Alexandru Vasile <[email protected]> * rustfmt: Change deprecated fmt Signed-off-by: Alexandru Vasile <[email protected]> * portable: Ensure no-std works Signed-off-by: Alexandru Vasile <[email protected]> * test_suite: Adjust UI tests to latest Signed-off-by: Alexandru Vasile <[email protected]> * Adjust UI tests with nightly Signed-off-by: Alexandru Vasile <[email protected]> * portable: Remove AtomicU32 Signed-off-by: Alexandru Vasile <[email protected]> * portable: Use DFS for recursive ID assignment Signed-off-by: Alexandru Vasile <[email protected]> * ty: Implement zero-alloc Default::default() for Type Signed-off-by: Alexandru Vasile <[email protected]> * portable: Change `retain` signature with FnMut Signed-off-by: Alexandru Vasile <[email protected]> * portable/tests: Apply clippy Signed-off-by: Alexandru Vasile <[email protected]> * git: Use clippy with `--all-targets` Signed-off-by: Alexandru Vasile <[email protected]> * ty: Make fields public to this crate `pub(crate)` only Signed-off-by: Alexandru Vasile <[email protected]> * portable: Use `mem` from `prelude` and not from `std` Signed-off-by: Alexandru Vasile <[email protected]> * retain * portable: Modify docs and apply fmt Signed-off-by: Alexandru Vasile <[email protected]> * portable/test: Check result BTreeMap Signed-off-by: Alexandru Vasile <[email protected]> * Fix cargo check Signed-off-by: Alexandru Vasile <[email protected]> * tests: Recursive retain for all type-def types Signed-off-by: Alexandru Vasile <[email protected]> * ty: Use placeholder instead of implementing dummy Default::default() Signed-off-by: Alexandru Vasile <[email protected]> * portable: use crate::prelude::vec![] insted of vec![] Signed-off-by: Alexandru Vasile <[email protected]> * Update src/portable.rs Co-authored-by: James Wilson <[email protected]> * portable: Fix clippy Signed-off-by: Alexandru Vasile <[email protected]> * Update src/portable.rs Co-authored-by: Andrew Jones <[email protected]> --------- Signed-off-by: Alexandru Vasile <[email protected]> Co-authored-by: James Wilson <[email protected]> Co-authored-by: Andrew Jones <[email protected]>
paritytech · Mar 21, 2023 · ce21de5 · ce21de5
1 parent 2721f93
commit ce21de5
Show file tree

Hide file tree

Showing 10 changed files with 588 additions and 30 deletions.
diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
@@ -31,7 +31,7 @@ jobs:
     - name: clippy
       run: |
         cargo clippy --version
-        cargo clippy --all -- -D warnings
+        cargo clippy --all-targets -- -D warnings
 
     - name: check-all-features
       run: |

diff --git a/.rustfmt.toml b/.rustfmt.toml
@@ -34,7 +34,7 @@ struct_field_align_threshold = 0
 enum_discrim_align_threshold = 0
 match_arm_blocks = true
 force_multiline_blocks = true # changed
-fn_args_layout = "Tall"
+fn_params_layout = "Tall"
 brace_style = "SameLineWhere"
 control_brace_style = "AlwaysSameLine"
 trailing_semicolon = false # changed

diff --git a/derive/src/trait_bounds.rs b/derive/src/trait_bounds.rs
@@ -104,7 +104,7 @@ pub fn make_where_clause<'a>(
         }
     });
 
-    generics.type_params().into_iter().for_each(|type_param| {
+    generics.type_params().for_each(|type_param| {
         let ident = type_param.ident.clone();
         let mut bounds = type_param.bounds.clone();
         if attrs