-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Babe fetch epoch returns a complete epoch #646
Conversation
Oh I didn't realize that you changed the output of the runtime function. |
Co-authored-by: Pierre Krieger <[email protected]>
Just so you're aware: this will break GrandPa warp sync until we do a runtime upgrade? |
I'm aware, I suggest we only merge after a runtime upgrade. |
Polkadot has been updated so I think we can merge this right? |
Ah, |
Only Westend has been updated. Polkadot and Kusama haven't. Fortunately, since we (erroneously?) use |
Ah, okay. |
This is now ok to merge. |
So this unfortunately breaks GrandPa warp sync on Westend because the config has changed to VRF and we still receive headers with plain slot claims. Asked André. |
So the story goes like this:
|
André changed the config with a sudo call in block 5,567,609. It's working again. |
* Babe fetch epoch returns a complete epoch * Update src/sync/grandpa_warp_sync.rs Co-authored-by: Pierre Krieger <[email protected]> * Use decode_all and update test Co-authored-by: Pierre Krieger <[email protected]>
This is to add the changes for paritytech/substrate#8072. I've tested it on a development substrate node and it works there, but on flaming fir I kept getting
Err(BabeFetchEpoch(WasmStart(VirtualMachine(FunctionNotFound), HostVmPrototype)))
, despite the chain being fully synced. I'm unsure whether that was caused by this change or not.