-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: staking payouts claimed with new logic & statuses #1457
Conversation
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ws](https://github.com/websockets/ws) from 8.5.0 to 8.17.1. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@8.5.0...8.17.1) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ws](https://github.com/websockets/ws) from 8.16.0 to 8.17.1. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@8.16.0...8.17.1) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* docs: add maintenance guide * add section for runtime upgrades * update README
* fix metric middleware * updated benchmarks' README.md to include new run all script * update to readmes * add dynamic metric creation * lint fix * updates error metric in error middleware * change preMiddleware * init: first try at route based metrics * lint clean * metrics by route function * route specific metrics * update to env * revert .gitignore * Remove yarn.lock * add yarn.lock * commit missing files * restore yarn.lock * fixes to metrics and docs update * update readme * update metrics naming * docs update
* feat: add pallets/on-going-referenda endpoint * updated docs * error handling when call not available - added also a test for that case * added test that returns referenda (call available) * replaced unnecessary Promise.all * small but nice improvements - added block height in the error msg (Tarik's review) - added a Promise.all (Filippo's review)
Bumps [axios](https://github.com/axios/axios) from 1.6.7 to 1.7.4. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.6.7...v1.7.4) --- updated-dependencies: - dependency-name: axios dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore(release): 19.1.0 * changed compatibility section (Iker review)
* wip metrics in controllers * Cleanup of metrics util into own directory * metrics registry injected in res object * cleanup * Route-based metrics by response object injection * Delete .env * resolve linting issues * fix extrinsics metric * update readme * update on comments * updated types to generics * update private function to emit metrics on blocks * update naming for metrics and README
Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.4 to 4.0.8. - [Release notes](https://github.com/micromatch/micromatch/releases) - [Changelog](https://github.com/micromatch/micromatch/blob/4.0.8/CHANGELOG.md) - [Commits](micromatch/micromatch@4.0.4...4.0.8) --- updated-dependencies: - dependency-name: micromatch dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Updates the config from env files to include metrics options * updates README * update loki transport * update readme * fix port number on metrics app * update query params metrics * fix import sidecarConfig * fix readme * fix .env and readme
…1483) * promise batching across services and controllers * injects historic api to fee calculation to reduce promises * adds notes to injected historic api
Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.5 to 4.0.8. - [Release notes](https://github.com/micromatch/micromatch/releases) - [Changelog](https://github.com/micromatch/micromatch/blob/4.0.8/CHANGELOG.md) - [Commits](micromatch/micromatch@4.0.5...4.0.8) --- updated-dependencies: - dependency-name: micromatch dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [cross-spawn](https://github.com/moxystudio/node-cross-spawn) from 7.0.3 to 7.0.6. - [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md) - [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.6) --- updated-dependencies: - dependency-name: cross-spawn dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [cross-spawn](https://github.com/moxystudio/node-cross-spawn) from 7.0.3 to 7.0.6. - [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md) - [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.6) --- updated-dependencies: - dependency-name: cross-spawn dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* rebase, fix script * add docs workflow * rename workflow * fix docs * fix docs publish * test publish * enable publish only for master * change condition
* docs: update docs & benchmarks related docs * updated the contributor s page
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.9.0 to 6.10.0. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v6.9.0...v6.10.0) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the pjs group with 5 updates: | Package | From | To | | --- | --- | --- | | [@polkadot/api](https://github.com/polkadot-js/api/tree/HEAD/packages/api) | `14.3.1` | `15.0.1` | | [@polkadot/api-augment](https://github.com/polkadot-js/api/tree/HEAD/packages/api-augment) | `14.3.1` | `15.0.1` | | [@polkadot/api-contract](https://github.com/polkadot-js/api/tree/HEAD/packages/api-contract) | `14.3.1` | `15.0.1` | | [@polkadot/types](https://github.com/polkadot-js/api/tree/HEAD/packages/types) | `14.3.1` | `15.0.1` | | [@polkadot/types-codec](https://github.com/polkadot-js/api/tree/HEAD/packages/types-codec) | `14.3.1` | `15.0.1` | Updates `@polkadot/api` from 14.3.1 to 15.0.1 - [Release notes](https://github.com/polkadot-js/api/releases) - [Changelog](https://github.com/polkadot-js/api/blob/master/CHANGELOG.md) - [Commits](https://github.com/polkadot-js/api/commits/v15.0.1/packages/api) Updates `@polkadot/api-augment` from 14.3.1 to 15.0.1 - [Release notes](https://github.com/polkadot-js/api/releases) - [Changelog](https://github.com/polkadot-js/api/blob/master/CHANGELOG.md) - [Commits](https://github.com/polkadot-js/api/commits/v15.0.1/packages/api-augment) Updates `@polkadot/api-contract` from 14.3.1 to 15.0.1 - [Release notes](https://github.com/polkadot-js/api/releases) - [Changelog](https://github.com/polkadot-js/api/blob/master/CHANGELOG.md) - [Commits](https://github.com/polkadot-js/api/commits/v15.0.1/packages/api-contract) Updates `@polkadot/types` from 14.3.1 to 15.0.1 - [Release notes](https://github.com/polkadot-js/api/releases) - [Changelog](https://github.com/polkadot-js/api/blob/master/CHANGELOG.md) - [Commits](https://github.com/polkadot-js/api/commits/v15.0.1/packages/types) Updates `@polkadot/types-codec` from 14.3.1 to 15.0.1 - [Release notes](https://github.com/polkadot-js/api/releases) - [Changelog](https://github.com/polkadot-js/api/blob/master/CHANGELOG.md) - [Commits](https://github.com/polkadot-js/api/commits/v15.0.1/packages/types-codec) --- updated-dependencies: - dependency-name: "@polkadot/api" dependency-type: direct:production update-type: version-update:semver-major dependency-group: pjs - dependency-name: "@polkadot/api-augment" dependency-type: direct:production update-type: version-update:semver-major dependency-group: pjs - dependency-name: "@polkadot/api-contract" dependency-type: direct:production update-type: version-update:semver-major dependency-group: pjs - dependency-name: "@polkadot/types" dependency-type: direct:production update-type: version-update:semver-major dependency-group: pjs - dependency-name: "@polkadot/types-codec" dependency-type: direct:production update-type: version-update:semver-major dependency-group: pjs ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [nanoid](https://github.com/ai/nanoid) from 3.3.7 to 3.3.8. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](ai/nanoid@3.3.7...3.3.8) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the pjs group with 5 updates: | Package | From | To | | --- | --- | --- | | [@polkadot/api](https://github.com/polkadot-js/api/tree/HEAD/packages/api) | `15.0.1` | `15.0.2` | | [@polkadot/api-augment](https://github.com/polkadot-js/api/tree/HEAD/packages/api-augment) | `15.0.1` | `15.0.2` | | [@polkadot/api-contract](https://github.com/polkadot-js/api/tree/HEAD/packages/api-contract) | `15.0.1` | `15.0.2` | | [@polkadot/types](https://github.com/polkadot-js/api/tree/HEAD/packages/types) | `15.0.1` | `15.0.2` | | [@polkadot/types-codec](https://github.com/polkadot-js/api/tree/HEAD/packages/types-codec) | `15.0.1` | `15.0.2` | Updates `@polkadot/api` from 15.0.1 to 15.0.2 - [Release notes](https://github.com/polkadot-js/api/releases) - [Changelog](https://github.com/polkadot-js/api/blob/master/CHANGELOG.md) - [Commits](https://github.com/polkadot-js/api/commits/v15.0.2/packages/api) Updates `@polkadot/api-augment` from 15.0.1 to 15.0.2 - [Release notes](https://github.com/polkadot-js/api/releases) - [Changelog](https://github.com/polkadot-js/api/blob/master/CHANGELOG.md) - [Commits](https://github.com/polkadot-js/api/commits/v15.0.2/packages/api-augment) Updates `@polkadot/api-contract` from 15.0.1 to 15.0.2 - [Release notes](https://github.com/polkadot-js/api/releases) - [Changelog](https://github.com/polkadot-js/api/blob/master/CHANGELOG.md) - [Commits](https://github.com/polkadot-js/api/commits/v15.0.2/packages/api-contract) Updates `@polkadot/types` from 15.0.1 to 15.0.2 - [Release notes](https://github.com/polkadot-js/api/releases) - [Changelog](https://github.com/polkadot-js/api/blob/master/CHANGELOG.md) - [Commits](https://github.com/polkadot-js/api/commits/v15.0.2/packages/types) Updates `@polkadot/types-codec` from 15.0.1 to 15.0.2 - [Release notes](https://github.com/polkadot-js/api/releases) - [Changelog](https://github.com/polkadot-js/api/blob/master/CHANGELOG.md) - [Commits](https://github.com/polkadot-js/api/commits/v15.0.2/packages/types-codec) --- updated-dependencies: - dependency-name: "@polkadot/api" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: pjs - dependency-name: "@polkadot/api-augment" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: pjs - dependency-name: "@polkadot/api-contract" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: pjs - dependency-name: "@polkadot/types" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: pjs - dependency-name: "@polkadot/types-codec" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: pjs ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [Swatinem/rust-cache](https://github.com/swatinem/rust-cache) from 2.7.5 to 2.7.7. - [Release notes](https://github.com/swatinem/rust-cache/releases) - [Changelog](https://github.com/Swatinem/rust-cache/blob/master/CHANGELOG.md) - [Commits](Swatinem/rust-cache@82a92a6...f0deed1) --- updated-dependencies: - dependency-name: Swatinem/rust-cache dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* init coretime * prep for coretime support * update coretime service: * feat: first iteration at coretime impl * fix coretime service * update blocks per timeslice * impl registries kusama and coretime chain v1003003 * housekeep for coretime tests * linting * tests passing for leases, renewals, regions * passing reservations * passing tests cores info * tests for cores endpoint * prep for api docs for coretime * coretime docs updated * reworked coretime/info endpoint to be more informative * change endpoint from cores to overview * passing tests * update docs * Delete .env * partial removal of typecasting * removal artifact code * patches to coretime controllers * patches to coretime controllers * patches to coretime controllers * patch docs
* chore(headers): 2025 * nits
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.10.0 to 6.11.0. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v6.10.0...v6.11.0) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
unclaimed = 'unclaimed', | ||
undefined = 'undefined', | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs to be updated in the docs as well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good point about the docs.
export interface IPayout { | ||
validatorId: string; | ||
nominatorStakingPayout: string; | ||
claimed: boolean; | ||
claimed: IStatus; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs to be updated in the docs as well! as before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! I will add it to the Todos in the description.
Bumps the pjs group with 5 updates: | Package | From | To | | --- | --- | --- | | [@polkadot/api](https://github.com/polkadot-js/api/tree/HEAD/packages/api) | `15.2.1` | `15.3.1` | | [@polkadot/api-augment](https://github.com/polkadot-js/api/tree/HEAD/packages/api-augment) | `15.2.1` | `15.3.1` | | [@polkadot/api-contract](https://github.com/polkadot-js/api/tree/HEAD/packages/api-contract) | `15.2.1` | `15.3.1` | | [@polkadot/types](https://github.com/polkadot-js/api/tree/HEAD/packages/types) | `15.2.1` | `15.3.1` | | [@polkadot/types-codec](https://github.com/polkadot-js/api/tree/HEAD/packages/types-codec) | `15.2.1` | `15.3.1` | Updates `@polkadot/api` from 15.2.1 to 15.3.1 - [Release notes](https://github.com/polkadot-js/api/releases) - [Changelog](https://github.com/polkadot-js/api/blob/master/CHANGELOG.md) - [Commits](https://github.com/polkadot-js/api/commits/v15.3.1/packages/api) Updates `@polkadot/api-augment` from 15.2.1 to 15.3.1 - [Release notes](https://github.com/polkadot-js/api/releases) - [Changelog](https://github.com/polkadot-js/api/blob/master/CHANGELOG.md) - [Commits](https://github.com/polkadot-js/api/commits/v15.3.1/packages/api-augment) Updates `@polkadot/api-contract` from 15.2.1 to 15.3.1 - [Release notes](https://github.com/polkadot-js/api/releases) - [Changelog](https://github.com/polkadot-js/api/blob/master/CHANGELOG.md) - [Commits](https://github.com/polkadot-js/api/commits/v15.3.1/packages/api-contract) Updates `@polkadot/types` from 15.2.1 to 15.3.1 - [Release notes](https://github.com/polkadot-js/api/releases) - [Changelog](https://github.com/polkadot-js/api/blob/master/CHANGELOG.md) - [Commits](https://github.com/polkadot-js/api/commits/v15.3.1/packages/types) Updates `@polkadot/types-codec` from 15.2.1 to 15.3.1 - [Release notes](https://github.com/polkadot-js/api/releases) - [Changelog](https://github.com/polkadot-js/api/blob/master/CHANGELOG.md) - [Commits](https://github.com/polkadot-js/api/commits/v15.3.1/packages/types-codec) --- updated-dependencies: - dependency-name: "@polkadot/api" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: pjs - dependency-name: "@polkadot/api-augment" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: pjs - dependency-name: "@polkadot/api-contract" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: pjs - dependency-name: "@polkadot/types" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: pjs - dependency-name: "@polkadot/types-codec" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: pjs ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@types/express-serve-static-core](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/express-serve-static-core) from 5.0.3 to 5.0.4. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/express-serve-static-core) --- updated-dependencies: - dependency-name: "@types/express-serve-static-core" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix: claimed in staking info endpoint * fix existing tests * add test for kusama (includes era 6508) * updated docs * implement new logic & update test responses * add test for partially claimed & overview = null * updated docs * output up until 84 eras & update tests * Remove yarn.lock files from PR * check before unwrapping & fix types * run linter * docs: added links & updated schema description * updated logic of claimed field for validator account - removed `partially claimed` value - added `undefined` value - updated tests * fix for claimed in case of validator account - bringing back `partially claimed` for validator * moved validator logic in separate function * adding first draft of nominator logic * nominator logic when validator era partially claimed - Added validator and nominator status types to allow specific status values for each - Updated existing test * added test for nominator * run linter * abstracting logic into separate functions * add implementation_details guide * remove docs dist * kept historical tests data but changed format * docs small update * Updated eras section & code comments * updated cases section in implementation guide * implemented optimization changes from Filippo * optimized era and depth calculation * updated claimedRewards & removed redundant check * updated eras function * updated implementation guide based on Filippos questions * updated the docs * add code_flow image in guide * updated copyright
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the description you wrote - changes look sane in relation to the parent PR.
Closing this PR in favor of #1579 |
Description
This PR is intended to be merged in this one #1436 and its changes are aligned with the
staking-info
updates from this PR #1445Changes
fetchCommissionAndLedger
tofetchCommissionLedgerAndClaimed
because it now also returnsclaimedRewards
.claimedRewards
is based on this PR for thestaking-info
endpoint.claimed
field returned fromstaking-payouts
is no longer a boolean value; It now has different statuses.undefined
was added which means that with the current information, we cannot determine if the rewards of the era were claimed, unclaimed or partially claimed.lastReward
and it is null, thenclaimed
is set toundefined
claimed
field, we wouldcontinue
/skip that era and do not return any info about that era. Now we don't, we just set the claimed field asundefined
.deriveEraPayouts
tofetchCommissionAndLedger
.era < 518
&& chain is Kusama is still working as expected. The era in this case is "automatically" considered asclaimed
.Testing
partially claimed
eraTodos
unclaimedOnly
to work with the new statuses.