Introduce Polkassembly API integration #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mordamax
reviewed
Jun 7, 2023
| if (!loginBody.token) { | ||
| throw new Error("Login unsuccessful, the authentication token is missing."); | ||
| } | ||
| this.token = loginBody.token; |
There was a problem hiding this comment.
may be worth adding some debug logs to login and signup?
mordamax
reviewed
Jun 7, 2023
| void (async () => { | ||
| const condition = async (): Promise<boolean> => { | ||
| const lastReferendum = await polkassembly.getLastReferendumNumber(track.track.trackNo); | ||
| return lastReferendum !== undefined && lastReferendum >= referendumId.toNumber(); |
There was a problem hiding this comment.
this could be vague and there's a chance that someone else right in the same moment posts a referendum to the same track, so we can endup with editing wrong post.
Small chance but exists
I'm curious if there would be more direct way to get a sense of referendum ID once we created this.
There was a problem hiding this comment.
Agree, there is a small chance it goes wrong.
I don't (yet) know if we can get the ID from the transaction callbacks.
mordamax
approved these changes
Jun 7, 2023
mutantcornholio
approved these changes
Jun 7, 2023
mutantcornholio
approved these changes
Jun 7, 2023
4 tasks
|
Note: I have listed some follow-up improvements here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a
Polkassemblyclass that integrates with the Polkassembly API.It works in two modes - with a Polkadot signer, and an Ethereum signer.
The Polkadot signer is to be used in production, and Ethereum signer was used to test it with the Moonbase Alpha.
Once we have another testnet with OpenGov and Polkassembly, we can remove the Ethereum portion.
For now I used Moonbase Alpha EMV chain to semi-manually test it.