This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
add iter-from for bags-list #11104
Merged
add iter-from for bags-list #11104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kianenigma
added
A0-please_review
ggwpez
approved these changes
Mar 24, 2022
| } else { | ||
| Err(()) | ||
| } | ||
| } |
There was a problem hiding this comment.
Could you maybe also add a minimal test here?
shawntabrizi
approved these changes
Mar 24, 2022
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
|
bot merge |
|
Waiting for commit status. |
|
Merge cancelled due to error. Error: Checks failed for c3eb6af |
|
bot merge |
|
Waiting for commit status. |
DaviRain-Su
pushed a commit
to octopus-network/substrate
that referenced
this pull request
Aug 23, 2022
* add iter-from for bags-list * Fix * Apply suggestions from code review Co-authored-by: Oliver Tale-Yazdi <[email protected]> * Fix Co-authored-by: Oliver Tale-Yazdi <[email protected]>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* add iter-from for bags-list * Fix * Apply suggestions from code review Co-authored-by: Oliver Tale-Yazdi <[email protected]> * Fix Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small backport needed in paritytech/polkadot-sdk#461
polkadot companion: paritytech/polkadot#5209