This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Implement ResultQuery #11257
Merged
Implement ResultQuery #11257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KiChjang
added
A0-please_review
frame/support/test/tests/pallet_ui/storage_result_query_multiple_type_args.rs
Outdated
Show resolved
Hide resolved
KiChjang
commented
Apr 28, 2022
bkchr
reviewed
May 10, 2022
|
bot rebase |
|
Rebasing |
shawntabrizi
approved these changes
May 25, 2022
kianenigma
approved these changes
Jul 12, 2022
|
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
A5-stale
stale
bot
removed
the
A5-stale
ggwpez
approved these changes
Aug 18, 2022
sam0x17
approved these changes
Aug 18, 2022
sam0x17
approved these changes
Aug 22, 2022
KiChjang
commented
Aug 24, 2022
| @@ -1436,6 +1532,8 @@ fn test_storage_info() { | |||
| traits::{StorageInfo, StorageInfoTrait}, | |||
| }; | |||
|
|
|||
| // Storage max size is calculated by adding up all the hasher size, the key type size and the | |||
| // value type size | |||
There was a problem hiding this comment.
|
bot merge |
|
Waiting for commit status. |
|
bot merge |
This was referenced Aug 24, 2022
2 tasks
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Implement ResultQuery * Fix test expectations * Add more tests * Fix test expectations * Clean up some names * Silence warnings * Specify error type when supplying error type to ResultQuery * cargo fmt * Add support for type parameters in parameter_types macro * Reduce deeply indented code * Fixes * Update test expectation * Rewrite and document formula for calculating max storage size * More docs * cargo fmt * formatting Co-authored-by: parity-processbot <>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11010.
Adds a new query type called
ResultQueryto the list of possible query kinds for storage items. We now haveOptionQuery,ValueQueryandResultQuery.To use it properly, one must also declare a pallet error enum, since that is what the
ResultQueryuses as theErrtype. When specifying the query type asResultQuery, a type parameter is expected, and instead of providing an actual type to it, the macro expects a type path that points to a variant of an enum that implementsPalletError, which will be used as theErrreturn value when a value is not found under the supplied storage key, i.e.StorageValue<_, u8, ResultQuery<PalletError<T>::EnumVariantName>>is the correct way to declare aStorageValuethat returns aResultcontaining anErrvalue ofErr(PalletError::<T>::EnumVariantName)when a value under the storage key is not found.