Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove duplicated contract dispatchables #12413

Closed
wants to merge 2 commits into from
Closed

Conversation

athei
Copy link
Member

@athei athei commented Oct 4, 2022

They do not provide compatibility as they are added under a new name. Clients need to adapt anyways to a new dry-run to learn about the proof size limit. Let's not add new duplicates in the meantime.

I will soon open a PR which will adapt fully to these changes (by returning the required pov size in the dry-run).

@athei athei added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. labels Oct 4, 2022
@athei athei requested review from ascjones and KiChjang October 4, 2022 09:07
@athei
Copy link
Member Author

athei commented Oct 4, 2022

This only exists for Calls which are encoded in storage (which do not depend on name). Not for submitting new extrinsics.

@athei athei closed this Oct 4, 2022
@athei athei deleted the at/remove-duplicates branch October 4, 2022 11:45
@athei
Copy link
Member Author

athei commented Oct 4, 2022

Superseded by #12421

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants