This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Only use substrate-wasm-builder
when std
feature is enabled.
#12790
Merged
paritytech-processbot
merged 2 commits into
paritytech:master
from
nazar-pc:std-only-wasm-builder
Jan 6, 2023
Merged
Only use substrate-wasm-builder
when std
feature is enabled.
#12790
paritytech-processbot
merged 2 commits into
paritytech:master
from
nazar-pc:std-only-wasm-builder
Jan 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 27, 2022
bkchr
approved these changes
Nov 30, 2022
jasl
added a commit
to Phala-Network/khala-parachain
that referenced
this pull request
Dec 14, 2022
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
A5-stale
Pull request did not receive any updates in a long time. No review needed at this stage. Close it.
label
Dec 31, 2022
@bkchr is there anything else that needs to be done here? |
stale
bot
removed
the
A5-stale
Pull request did not receive any updates in a long time. No review needed at this stage. Close it.
label
Jan 6, 2023
No! Just a second approval is missing :D |
bot rebase |
Rebased |
melekes
approved these changes
Jan 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
michalkucharczyk
approved these changes
Jan 6, 2023
bkchr
added
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
labels
Jan 6, 2023
bot merge |
Waiting for commit status. |
ltfschoen
pushed a commit
to ltfschoen/substrate
that referenced
this pull request
Feb 22, 2023
…itytech#12790) Co-authored-by: parity-processbot <>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
…itytech#12790) Co-authored-by: parity-processbot <>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a much simpler version of #12786 that achieves the same result. Mostly an example for other projects to follow.