This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Forbid stray tokens in call index #13036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ggwpez PTAL. |
bkchr
approved these changes
Dec 31, 2022
bkchr
reviewed
Jan 1, 2023
Co-authored-by: Bastian Köcher <[email protected]>
ggwpez
approved these changes
Jan 2, 2023
There was a problem hiding this comment.
Thanks!
Just as a note, you can run the pallet ui tests locally instead of relying on the CI. Eg for your call index test:
RUN_UI_TESTS=1 rustup run 1.65 cargo test -p frame-support-test -- pallet_ui trybuild=call_index_has_suffix.rsAnd optional with TRYBUILD=overwrite to overwrite the stderr files.
ggwpez
added
A0-please_review
|
bot merge |
|
Waiting for commit status. |
ltfschoen
pushed a commit
to ltfschoen/substrate
that referenced
this pull request
Feb 22, 2023
* Check for call_index * fixes * pallet ui test for weight attribute * Update frame/support/procedural/src/pallet/parse/call.rs Co-authored-by: Bastian Köcher <[email protected]> * fix * small fix * wrong return type * ... * . * final fix * update .stderr * commit * udpate * Update frame/support/procedural/src/pallet/parse/call.rs Co-authored-by: Bastian Köcher <[email protected]> * update .stderr Co-authored-by: Bastian Köcher <[email protected]>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Check for call_index * fixes * pallet ui test for weight attribute * Update frame/support/procedural/src/pallet/parse/call.rs Co-authored-by: Bastian Köcher <[email protected]> * fix * small fix * wrong return type * ... * . * final fix * update .stderr * commit * udpate * Update frame/support/procedural/src/pallet/parse/call.rs Co-authored-by: Bastian Köcher <[email protected]> * update .stderr Co-authored-by: Bastian Köcher <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #12954