Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Benchmark execution times of runtime calls using Wasm execution. #3336

Closed
wants to merge 1 commit into from

Conversation

jimpo
Copy link
Contributor

@jimpo jimpo commented Aug 8, 2019

These benchmarks were useful in measuring the impact of #3011.

@jimpo jimpo requested a review from pepyakin August 8, 2019 08:33
@bkchr
Copy link
Member

bkchr commented Aug 8, 2019

@jimpo
Copy link
Contributor Author

jimpo commented Aug 9, 2019

@bkchr Thanks, didn't know about those. I don't see any benchmarks for a full block import. Do you know if that exists? Also, I need to check that going through the runtime API doesn't add much overhead over the more targeted benchmark using the lower-level APIs, but I assume it wouldn't.

@bkchr
Copy link
Member

bkchr commented Aug 9, 2019

The runtime api uses the same api internally as you are using. I'm not aware of any full block import benchmark.

@kianenigma
Copy link
Contributor

I have a question: How close are these to a realistic execution?

(I am pretty sure I asked this in some technical chat but have no memory of what was the answer): How often do we, in reality, spawn a new executor?

About the code: we also directly benchmark executor in node/executor. If you really care about something within the executor, then it makes the most sense to actually do it from there imo.

@bkchr
Copy link
Member

bkchr commented Aug 9, 2019

As he wanted to measure the impact of the runtime caching, it is more like a high level benchmark anyway.

@gavofyork gavofyork added the A0-please_review Pull request needs code review. label Aug 21, 2019
@pepyakin
Copy link
Contributor

As an aside, I wonder if test-runtime would be a better place than sr-api-macros for housing the benches?

@jimpo
Copy link
Contributor Author

jimpo commented Aug 27, 2019

Closing for now until I have time to rework it.

@jimpo jimpo closed this Aug 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants