Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Get rid of in-substrate usages of core_intrinsics feature #4823

Merged
merged 4 commits into from
Feb 5, 2020

Conversation

pepyakin
Copy link
Contributor

@pepyakin pepyakin commented Feb 4, 2020

Removes all instances of usage core_intrinsics. In two cases they were really useless. In the third case, we could substitute it with a call to core::arch::wasm32::unreachable which is stable.

One little step towards #1252

The behavior hasn't changed, thus no bumping of runtime is required.

@pepyakin pepyakin added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes labels Feb 4, 2020
@pepyakin
Copy link
Contributor Author

pepyakin commented Feb 4, 2020

The CI failure implies that the nightly used is rather old.

@bkchr
Copy link
Member

bkchr commented Feb 4, 2020

But why does it work for the main build where we build the wasm blobs? Hmm.

@pepyakin
Copy link
Contributor Author

pepyakin commented Feb 4, 2020

My hypothesis is that the gitlab-test-full-crypto-feature job uses an outdated nightly. I am not sure though, @gabreal might be able to confirm this.

@pepyakin
Copy link
Contributor Author

pepyakin commented Feb 4, 2020

Ok, failure is in fact legit: core::arch::wasm32 is only available for wasm32 and for some reason we compile sr-io for no_std but not wasm32 (probably, SGX?).

I think I am inclined to disable panic_handler and alloc_error_handler since they are disabled for those use-cases anyway.

@gavofyork gavofyork merged commit 4e0e8c1 into master Feb 5, 2020
@gavofyork gavofyork deleted the ser-remove-useless-features branch February 5, 2020 16:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants