This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Output Benchmarks to File #6481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* hardcoded whitelist * Add whitelist to pipeline * Remove whitelist pipeline from CLI, add to runtime * clean-up unused db initialized whitelist
* Add selector * add tests * debug formatter for easy formula
github-actions
bot
added
the
A3-in_progress
apopiak
reviewed
Jul 3, 2020
| fn close_early_disapproved(_m: u32, _p: u32, _b: u32, ) -> Weight { 1_000_000_000 } | ||
| fn close_early_approved(_m: u32, _p: u32, _b: u32, ) -> Weight { 1_000_000_000 } | ||
| fn close_disapproved(_m: u32, _p: u32, _b: u32, ) -> Weight { 1_000_000_000 } | ||
| fn close_approved(_m: u32, _p: u32, _b: u32, ) -> Weight { 1_000_000_000 } |
There was a problem hiding this comment.
I do wonder whether we should rather default to 0 for these default implementations because that seems like the current default. Either has its drawbacks I guess 🤷
There was a problem hiding this comment.
yeah, its kind of just an opinion. im open to whatever, but my thought is that its better to stick a crazy number than to make it zero.
shawntabrizi
changed the base branch from
master
to
shawntabrizi-benchmarks-writer
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in progress