Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Migrate more pallet tests to construct_runtime #8051

Merged
5 commits merged into from
Feb 4, 2021

Conversation

ascjones
Copy link
Contributor

@ascjones ascjones commented Feb 4, 2021

Part of #7949. Migrates the following crate test runtimes to construct_runtime :

  • bounties
  • contracts
  • democracy

@ascjones ascjones requested a review from athei as a code owner February 4, 2021 15:40
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Feb 4, 2021
Copy link
Member

@shawntabrizi shawntabrizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this compiles, looks good to me

type Treasury = pallet_treasury::Module<Test>;
type Bounties = Module<Test>;

type TreasuryEvent = pallet_treasury::Error::<Test, pallet_treasury::DefaultInstance>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be renamed TreasuryError

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Er yeah just checking you were paying attention 😅

@gui1117 gui1117 added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Feb 4, 2021
@gui1117
Copy link
Contributor

gui1117 commented Feb 4, 2021

bot merge

@ghost
Copy link

ghost commented Feb 4, 2021

Waiting for commit status.

@ghost ghost merged commit 6105169 into master Feb 4, 2021
@ghost ghost deleted the aj-tests-use-construct-runtime branch February 4, 2021 16:34
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants