Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove suicide from frame_system weights #8184

Merged
4 commits merged into from
Feb 23, 2021
Merged

Conversation

s3krit
Copy link
Contributor

@s3krit s3krit commented Feb 23, 2021

companion: paritytech/polkadot#2506
Suicide was removed in #7363 - this change just removes the weights for these calls.

@s3krit s3krit added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Feb 23, 2021
@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). and removed A0-please_review Pull request needs code review. labels Feb 23, 2021
@bkchr bkchr requested a review from shawntabrizi February 23, 2021 14:16
@shawntabrizi
Copy link
Member

/benchmark runtime pallet frame_system

@parity-benchapp
Copy link

parity-benchapp bot commented Feb 23, 2021

Finished benchmark for branch: mp-remove-suicide-weights

Benchmark: Benchmark Runtime Pallet

cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=frame_system --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/system/src/weights.rs --template=./.maintain/frame-weight-template.hbs

Results

Pallet: "frame_system", Extrinsic: "remark", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 1.285
+ b 0
µs

Reads = 0 + (0 * b)
Writes = 0 + (0 * b)
Min Squares Analysis

-- Extrinsic Time --

Data points distribution:
b mean µs sigma µs %
0 1.182 0.008 0.6%
78643 1.289 0.014 1.0%
157286 1.292 0.013 1.0%
235929 1.295 0.012 0.9%
314572 1.294 0.015 1.1%
393215 1.308 0.011 0.8%
471858 1.312 0.015 1.1%
550501 1.325 0.015 1.1%
629144 1.283 0.012 0.9%
707787 1.315 0.005 0.3%
786430 1.298 0.013 1.0%
865073 1.31 0.006 0.4%
943716 1.314 0.007 0.5%
1022359 1.309 0.02 1.5%
1101002 1.292 0.011 0.8%
1179645 1.31 0.01 0.7%
1258288 1.292 0.007 0.5%
1336931 1.317 0.02 1.5%
1415574 1.314 0.015 1.1%
1494217 1.306 0.009 0.6%
1572860 1.293 0.005 0.3%
1651503 1.296 0.007 0.5%
1730146 1.318 0.006 0.4%
1808789 1.318 0.014 1.0%
1887432 1.303 0.007 0.5%
1966075 1.31 0.011 0.8%
2044718 1.287 0.013 1.0%
2123361 1.316 0.013 0.9%
2202004 1.317 0.009 0.6%
2280647 1.344 0.012 0.8%
2359290 1.345 0.011 0.8%
2437933 1.324 0.013 0.9%
2516576 1.312 0.013 0.9%
2595219 1.334 0.013 0.9%
2673862 1.337 0.012 0.8%
2752505 1.329 0.015 1.1%
2831148 1.337 0.02 1.4%
2909791 1.326 0.012 0.9%
2988434 1.339 0.018 1.3%
3067077 1.35 0.018 1.3%
3145720 1.338 0.015 1.1%
3224363 1.339 0.022 1.6%
3303006 1.34 0.015 1.1%
3381649 1.345 0.015 1.1%
3460292 1.352 0.02 1.4%
3538935 1.349 0.014 1.0%
3617578 1.338 0.015 1.1%
3696221 1.383 0.027 1.9%
3774864 1.361 0.013 0.9%
3853507 1.359 0.011 0.8%
3932150 1.386 0.025 1.8%

Quality and confidence:
param error
b 0

Model:
Time ~= 1.279
+ b 0
µs

Reads = 0 + (0 * b)
Writes = 0 + (0 * b)
Pallet: "frame_system", Extrinsic: "set_heap_pages", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 2.167
µs

Reads = 0
Writes = 1
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 2.167
µs

Reads = 0
Writes = 1
Pallet: "frame_system", Extrinsic: "set_changes_trie_config", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 10.11
µs

Reads = 1
Writes = 2
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 10.11
µs

Reads = 1
Writes = 2
Pallet: "frame_system", Extrinsic: "set_storage", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 0
+ i 0.607
µs

Reads = 0 + (0 * i)
Writes = 0 + (1 * i)
Min Squares Analysis

-- Extrinsic Time --

Data points distribution:
i mean µs sigma µs %
1 2.031 0.014 0.6%
20 12.52 0.067 0.5%
39 23.55 0.096 0.4%
58 34.9 0.127 0.3%
77 45.82 0.072 0.1%
96 56.91 0.093 0.1%
115 69.81 0.713 1.0%
134 80.37 0.187 0.2%
153 91.84 0.158 0.1%
172 102.8 0.137 0.1%
191 115.9 0.206 0.1%
210 126.6 0.23 0.1%
229 138.9 0.228 0.1%
248 150.4 0.305 0.2%
267 161.5 0.267 0.1%
286 172.9 0.189 0.1%
305 181.8 0.169 0.0%
324 196.2 0.283 0.1%
343 207.3 0.317 0.1%
362 218.1 0.438 0.2%
381 229 0.449 0.1%
400 240.1 0.148 0.0%
419 252.4 0.836 0.3%
438 265.6 0.548 0.2%
457 276.6 0.413 0.1%
476 287.4 0.361 0.1%
495 298.3 0.396 0.1%
514 308.9 0.366 0.1%
533 323.1 0.331 0.1%
552 333.2 0.231 0.0%
571 343.9 0.552 0.1%
590 355.8 0.468 0.1%
609 367.4 0.338 0.0%
628 378.6 0.442 0.1%
647 391.8 2.79 0.7%
666 401 0.438 0.1%
685 413.5 0.633 0.1%
704 426.7 0.931 0.2%
723 438.4 0.597 0.1%
742 449 0.239 0.0%
761 459.7 1.275 0.2%
780 475.1 0.588 0.1%
799 482.2 0.313 0.0%
818 495.6 0.386 0.0%
837 506.5 0.715 0.1%
856 521.5 0.741 0.1%
875 533.9 0.662 0.1%
894 543.7 0.569 0.1%
913 555 0.372 0.0%
932 566 1.008 0.1%
951 579.1 0.512 0.0%
970 589.9 0.9 0.1%
989 603.6 0.4 0.0%

Quality and confidence:
param error
i 0

Model:
Time ~= 0
+ i 0.608
µs

Reads = 0 + (0 * i)
Writes = 0 + (1 * i)
Pallet: "frame_system", Extrinsic: "kill_storage", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 0.711
+ i 0.453
µs

Reads = 0 + (0 * i)
Writes = 0 + (1 * i)
Min Squares Analysis

-- Extrinsic Time --

Data points distribution:
i mean µs sigma µs %
1 1.993 0.018 0.9%
20 9.925 0.062 0.6%
39 17.69 0.044 0.2%
58 25.75 0.092 0.3%
77 34.4 0.105 0.3%
96 42.45 0.186 0.4%
115 51.86 0.171 0.3%
134 60.6 0.132 0.2%
153 69.37 0.372 0.5%
172 77.15 0.124 0.1%
191 87.01 0.16 0.1%
210 95.01 0.244 0.2%
229 103.4 0.263 0.2%
248 113.3 0.264 0.2%
267 121.9 0.358 0.2%
286 131.1 0.212 0.1%
305 137.8 0.212 0.1%
324 149.5 0.523 0.3%
343 158 0.222 0.1%
362 166.2 0.29 0.1%
381 174.4 0.253 0.1%
400 184 0.224 0.1%
419 193.2 0.306 0.1%
438 204 0.213 0.1%
457 213.7 0.398 0.1%
476 221.8 0.321 0.1%
495 231.2 0.307 0.1%
514 245.1 0.465 0.1%
533 256.9 0.264 0.1%
552 266.4 0.381 0.1%
571 268.9 0.903 0.3%
590 278.2 0.508 0.1%
609 287.4 0.558 0.1%
628 294.8 5.286 1.7%
647 305.1 0.712 0.2%
666 304.5 8.493 2.7%
685 303 0.754 0.2%
704 312.8 0.294 0.0%
723 327.8 1.81 0.5%
742 332 2.79 0.8%
761 339.7 2.573 0.7%
780 350.4 1.948 0.5%
799 363.9 9.63 2.6%
818 365.5 2.418 0.6%
837 374.1 2.854 0.7%
856 383.3 0.548 0.1%
875 394.8 2.892 0.7%
894 401.6 0.571 0.1%
913 409.9 0.613 0.1%
932 417.4 0.488 0.1%
951 428.7 0.302 0.0%
970 435.5 0.558 0.1%
989 446.7 0.328 0.0%

Quality and confidence:
param error
i 0

Model:
Time ~= 3.199
+ i 0.45
µs

Reads = 0 + (0 * i)
Writes = 0 + (1 * i)
Pallet: "frame_system", Extrinsic: "kill_prefix", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 4.731
+ p 0.856
µs

Reads = 0 + (0 * p)
Writes = 0 + (1 * p)
Min Squares Analysis

-- Extrinsic Time --

Data points distribution:
p mean µs sigma µs %
1 4.733 0.048 1.0%
20 21.47 0.083 0.3%
39 37.7 0.577 1.5%
58 55.13 0.15 0.2%
77 67.67 0.46 0.6%
96 83.13 0.3 0.3%
115 97.97 1.075 1.0%
134 114.1 0.358 0.3%
153 131.1 0.513 0.3%
172 148.7 0.298 0.2%
191 163.5 0.344 0.2%
210 180.4 0.342 0.1%
229 198.6 0.433 0.2%
248 211.4 0.845 0.3%
267 229 1.33 0.5%
286 253.7 7.651 3.0%
305 264.4 3.955 1.4%
324 285.5 2.807 0.9%
343 302.3 3.39 1.1%
362 322.3 0.601 0.1%
381 343.3 3.707 1.0%
400 351.5 4.935 1.4%
419 370.1 1.165 0.3%
438 384.6 2.377 0.6%
457 395.2 2.619 0.6%
476 417.4 1.065 0.2%
495 429.9 0.676 0.1%
514 445.4 4.307 0.9%
533 465.1 0.45 0.0%
552 478.8 0.854 0.1%
571 497.1 3.274 0.6%
590 517.7 9.871 1.9%
609 520.5 1.081 0.2%
628 555.9 11.58 2.0%
647 580.2 10.96 1.8%
666 600.2 6.392 1.0%
685 596.2 1.941 0.3%
704 627.7 13.16 2.0%
723 624.1 12.72 2.0%
742 644.4 9.916 1.5%
761 661.5 6 0.9%
780 674.5 4.379 0.6%
799 688.5 8.072 1.1%
818 704.8 3.423 0.4%
837 721.8 5.504 0.7%
856 712.2 4.473 0.6%
875 729.4 10.86 1.4%
894 737.3 5.991 0.8%
913 757.1 8.416 1.1%
932 792.2 16.12 2.0%
951 787 1.894 0.2%
970 821.7 11.28 1.3%
989 832.1 17.09 2.0%

Quality and confidence:
param error
p 0.001

Model:
Time ~= 8.966
+ p 0.845
µs

Reads = 0 + (0 * p)
Writes = 0 + (1 * p)

Parity Benchmarking Bot added 2 commits February 23, 2021 16:31
…/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=frame_system --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/system/src/weights.rs --template=./.maintain/frame-weight-template.hbs
@s3krit
Copy link
Contributor Author

s3krit commented Feb 23, 2021

bot merge

@ghost
Copy link

ghost commented Feb 23, 2021

Waiting for commit status.

@ghost ghost merged commit ad8c585 into master Feb 23, 2021
@ghost ghost deleted the mp-remove-suicide-weights branch February 23, 2021 17:37
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants