This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add BalanceToAssetBalance Conversion Type #8776
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
converts based on a given existential deposit and the assets min_balance
apopiak
added
A0-please_review
kianenigma
reviewed
May 11, 2021
frame/assets/src/types.rs
Outdated
Comment on lines
203
to
207
| impl<T: Config, Balance, ED> BalanceToAssetBalance<T, Balance, ED> | ||
| where | ||
| Balance: Into<<T as Config>::Balance> + FixedPointOperand + Ord + One, | ||
| <T as Config>::Balance: FixedPointOperand, | ||
| ED: Get<Balance>, |
There was a problem hiding this comment.
Suggested change
| impl<T: Config, Balance, ED> BalanceToAssetBalance<T, Balance, ED> | |
| where | |
| Balance: Into<<T as Config>::Balance> + FixedPointOperand + Ord + One, | |
| <T as Config>::Balance: FixedPointOperand, | |
| ED: Get<Balance>, | |
| impl<T, Balance, ED> BalanceToAssetBalance<T, Balance, ED> | |
| where | |
| T: Config, | |
| <T as Config>::Balance: FixedPointOperand, | |
| Balance: Into<<T as Config>::Balance> + FixedPointOperand + Ord + One, | |
| ED: Get<Balance>, |
kianenigma
reviewed
May 11, 2021
frame/assets/src/types.rs
Outdated
| /// deposit and the minimum asset balance. | ||
| /// | ||
| /// Will return `Err` if the asset is not found or not sufficient. | ||
| pub fn to_asset_balance(balance: Balance, asset_id: <T as Config>::AssetId) -> Result<<T as Config>::Balance, ConversionError> { |
There was a problem hiding this comment.
if there's no trait to be fulfilled, you might as well just expose a function rather than a struct.
kianenigma
reviewed
May 11, 2021
kianenigma
reviewed
May 11, 2021
There was a problem hiding this comment.
-
Why does this need to be here in substrate? seems like the type of thing that should live where it is used.
-
If so, I'd rewrite it as:
/// Convert from the native balance of a currency (e.g. an instance of [`pallet_balances`])
/// to the native balance of an asset pallet.
fn balance_to_asset<Balance: Currency, Asset: Config>(from: Balances::Balance, to: Asset::AssetId)
where
Balances::Balance: ...,
T::Balance: ...,
{
let ed = Balances::minimum_balance();
// blah blah
}
Because it accesses private state (namely the |
|
I could access |
|
Can you provide a branch where this is used in it? or pseudo code of how it should fit in the mentioned PR. |
|
(branch does not compile yet) |
|
superseded by #9076 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
BalanceToAssetBalancetype topallet_assetsto allow converting native balances to asset specific ones.This is a "low resolution" conversion based on the existential deposit (of the native currency) and the
min_balance(of the asset).needed (AFAICT) for paritytech/statemint#51
Questions: