This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
grandpa: restrict grandpa gossip #9131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresilva
added
A0-please_review
ordian
approved these changes
Jun 17, 2021
|
bot merge |
|
Trying merge. |
|
Bot will approve on the behalf of @andresilva, since they are a team lead, in an attempt to reach the minimum approval count |
ghost
merged commit 
ghost
approved these changes
Jun 18, 2021
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the GRANDPA gossip validator to make it more restrictive. Currently there is a lot of duplicate messages being exchanged. Additionally this should also make gossip more fair as we were heavily favoring gossiping to authorities to the point that full nodes cannot keep up with the latest rounds (they were mostly keeping up with finality through commits and catch-up requests).
We already deployed this on all of the rococo validators and the traffic went down by about 3x without introducing any delay in finality.