Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Support NMap in generate_storage_alias #9147

Merged
5 commits merged into from
Jun 28, 2021
Merged

Support NMap in generate_storage_alias #9147

5 commits merged into from
Jun 28, 2021

Conversation

KiChjang
Copy link
Contributor

@KiChjang KiChjang added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jun 19, 2021
@KiChjang KiChjang requested review from kianenigma and gui1117 June 19, 2021 02:42
@gui1117 gui1117 mentioned this pull request Aug 24, 2023
Open
gui1117
gui1117 reviewed Jun 21, 2021
View reviewed changes
frame/support/src/lib.rs Show resolved Hide resolved
frame/support/src/lib.rs Show resolved Hide resolved
@gui1117
Copy link
Contributor

gui1117 commented Jun 23, 2021

you probably just need to merge master to fix tests

@KiChjang KiChjang requested review from apopiak and coriolinus June 25, 2021 23:39
@KiChjang
Copy link
Contributor Author

bot merge

@ghost
Copy link

ghost commented Jun 28, 2021

Trying merge.

@ghost ghost merged commit c2d6fa7 into master Jun 28, 2021
@ghost ghost deleted the kckyeung/support-nmap-in-generate-storage-alias branch June 28, 2021 09:17
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gui1117 gui1117 gui1117 approved these changes

@coriolinus coriolinus coriolinus approved these changes

@kianenigma kianenigma Awaiting requested review from kianenigma

@apopiak apopiak Awaiting requested review from apopiak

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KiChjang @gui1117 @coriolinus