Dev #22
Merged
Dev #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Embed COSMIC catalogs inside the package.
add refitting with sparsity and reassign in Denovo class
Validation for denovo and refitting calculations
… DenovoSig 1. Parallelized wrappedMVNMF and make that parallelization compatible with the parallelization in DenovoSig. Performed tests showing expected gain in running time. 2. In DenovoSig, added attributes to save the raw W's and H's from each replicate run, also added attributes to save the selected lambda_tilde for mvNMF.
Some of the catalog data files are not in the correct order for the 96 features. Those are corrected.
First remove bad solutions. Then do clustering. This gives better results overall.
When the solutions from all replicates have the same reconstruction error, previous code will throw an error. Now that is taken care of by replacing < by <=.
1. We should perform filtering at the beginning. It is possible that after filtering, there is only one solution left. So we move filtering to before "if len(Ws) == 1". 2. We save the number of solutions after filtering to self.n_replicates_after_filtering_all. Comparing this number to self.n_replicates gives an idea of how many solutions are considered bad and thus filtered out. If too many solutions are filtered out, then it might be a problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.