Skip to content
This repository was archived by the owner on Jan 18, 2023. It is now read-only.

Add support for setting slack application in deploy #1

Merged
merged 4 commits into from
Feb 11, 2015

Conversation

RyanMacG
Copy link
Contributor

Allow for users to set :slack_application in their deploy files without changing default behaviour if they don't.

@parkr
Copy link
Owner

parkr commented Feb 10, 2015

Hey @RyanMacG! Thanks for the pull request. :) What's your motivation for this? Thanks!

@RyanMacG
Copy link
Contributor Author

I'm a previous user of capistrano-slack and enjoyed having the functionality there. Also at work we use the application's URL for :application which means all of our deploys have odd links in them as a result.

I get that it might be a niche feature but it's one I'm fond of

@parkr
Copy link
Owner

parkr commented Feb 10, 2015

Ok, no problem.

There's another line that's using fetch(:application) – can you update that as well? We should probably use a helper method like #slack_application.

@parkr
Copy link
Owner

parkr commented Feb 10, 2015

What do you think about slack_app_name instead of slack_application?

@RyanMacG
Copy link
Contributor Author

That sounds good to me, I'll make these changes and push them up

@@ -36,6 +36,10 @@ def slack_webhook_url
fetch(:slack_webhook_url)
end

def slack_application
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be consistent with the variable name, i.e. slack_app_name?

@parkr parkr merged commit 93743dc into parkr:master Feb 11, 2015
@parkr
Copy link
Owner

parkr commented Feb 11, 2015

Thanks mate!

parkr added a commit that referenced this pull request Feb 11, 2015
@parkr
Copy link
Owner

parkr commented Feb 12, 2015

Released in 1.1.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants