-
Notifications
You must be signed in to change notification settings - Fork 24
Add support for setting slack application in deploy #1
Conversation
Hey @RyanMacG! Thanks for the pull request. :) What's your motivation for this? Thanks! |
I'm a previous user of capistrano-slack and enjoyed having the functionality there. Also at work we use the application's URL for I get that it might be a niche feature but it's one I'm fond of |
Ok, no problem. There's another line that's using |
What do you think about |
That sounds good to me, I'll make these changes and push them up |
@@ -36,6 +36,10 @@ def slack_webhook_url | |||
fetch(:slack_webhook_url) | |||
end | |||
|
|||
def slack_application |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be consistent with the variable name, i.e. slack_app_name
?
Thanks mate! |
Released in 1.1.0 |
Allow for users to set
:slack_application
in their deploy files without changing default behaviour if they don't.