Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore lines between coveralls-ignore-start and coveralls-ignore-stop comments #183

Merged
merged 2 commits into from
May 12, 2019

Conversation

mruoss
Copy link
Contributor

@mruoss mruoss commented May 7, 2019

This pull request addresses issue #177.

The approach is inspired by the stop-words implementation and ignores all code between #coveralls-ignore-start and #coveralls-ignore-stop in the coverage calculation

It might not be the most beautiful solution but it helps us a great deal to reach 100% test coverage.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 89.63% when pulling 4792329 on ufirstgroup:support-comments-to-ignore-lines into 80da82f on parroty:master.

@coveralls
Copy link

coveralls commented May 7, 2019

Coverage Status

Coverage increased (+0.2%) to 89.604% when pulling 762500b on ufirstgroup:support-comments-to-ignore-lines into 80da82f on parroty:master.

@mruoss mruoss force-pushed the support-comments-to-ignore-lines branch from 4792329 to 8928e36 Compare May 7, 2019 07:21
@parroty parroty merged commit 468b6b4 into parroty:master May 12, 2019
@parroty
Copy link
Owner

parroty commented May 12, 2019

Thanks!

@adropofilm
Copy link

NICE! Thank you so much!!! This is so useful!

@mruoss
Copy link
Contributor Author

mruoss commented May 13, 2019

Thanks @adropofilm
I would prefer a solution where we could annotate modules and functions with tags but this is a quick win. Maybe I get to refactor it later.

@RKushnir
Copy link
Contributor

The link to the post is no longer working. Since I'm also a fan of the idea of 100% code coverage, here's an archived version of that post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants