Add Custom Filename support for coveralls.json #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@parroty - Any thoughts on this one? |
|
Thanks for the update 🙇 . Could you help me to add some usage examples for understanding the behavior well? (maybe in the README?). I am assuming the default behavior doesn't change and adding this new option might not break existing usage. |
|
Hey! So the default behavior is not changed at all, really I wanted a mechanism to piggyback on the existing Currently in a coveralls.json export, the file would be named I'll add a little spot in the readme for it |
|
@parroty README updated |
|
Thank you (and sorry being late to respond), please allow some time to publish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When running an umbrella app's coveralls in partitioned instances - a way to specify reports is needed for tools like CodeCov to merge reports - this is helpful when running GH actions as a matrix for each app, or even if running the same app in partitions.
Proposal
Leverage the same
exportflag that exists for.coverdatafiles and allow the name to be used instead of the hardcodedexcoveralls.jsonif it exists. That way predictable filenames can be given and default behaviour preserved.