Add classname to browser title #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flovilmart
reviewed
Oct 13, 2018
| @@ -32,6 +32,7 @@ import styles from 'dashboard/Data/Browser/Browser.s | |||
| import subscribeTo from 'lib/subscribeTo'; | |||
| import * as ColumnPreferences from 'lib/ColumnPreferences'; | |||
| import * as queryString from 'query-string'; | |||
| import DocumentTitle from 'react-document-title'; | |||
There was a problem hiding this comment.
I’m always cautious when adding new dependencies.
Did you consider Helmet? It is well maintained and popular.
paulovitin
changed the title
paulovitin
changed the title
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@flovilmart need something more here? |
flovilmart
approved these changes
Jan 10, 2019
|
Thansk!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title of browser with class name currently opened #868