Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FilesController.js #1309

Closed
wants to merge 1 commit into from

Conversation

mcclaskiem
Copy link

config was removed from calling createFile on adapter causing errors on save

`config` was removed from calling createFile on adapter causing errors on save
@mcclaskiem
Copy link
Author

Updated to 2.2.4 today via NPM and saving files was broken. Noticed this issue but wanted to confirm so re-opening

@flovilmart
Copy link
Contributor

Which adapter is broken? this has been discussed here originally: #1172

And we agreed to move forward as the config parameter was never used by any adapters

@mcclaskiem
Copy link
Author

O gotcha I was using config for rack space and I saw S3 was using it as well in my node_modules but I can easily rewrite the rack space one to not use it.

@flovilmart
Copy link
Contributor

https://github.com/parse-server-modules/parse-server-conformance-tests is the guideline for the files adapter, you can find plenty of examples across the https://github.com/parse-server-modules organization.

Sorry for the breaking change.

@flovilmart flovilmart closed this Mar 31, 2016
@flovilmart
Copy link
Contributor

@mcclaskiem do you explicitly need the config or this was to match the API?

@mcclaskiem
Copy link
Author

I was just trying to match the API at the time but I will go ahead and reconfigure my adapter. Thanks for the insight on updates!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants