Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add production Google Auth Adapter instead of using the development url #6734

Merged
merged 3 commits into from
Jul 15, 2020

Conversation

SebC99
Copy link
Contributor

@SebC99 SebC99 commented Jun 12, 2020

Related to #6652

@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #6734 into master will decrease coverage by 0.06%.
The diff coverage is 92.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6734      +/-   ##
==========================================
- Coverage   93.91%   93.84%   -0.07%     
==========================================
  Files         169      169              
  Lines       12029    12080      +51     
==========================================
+ Hits        11297    11337      +40     
- Misses        732      743      +11     
Impacted Files Coverage Δ
src/Adapters/Auth/google.js 92.75% <92.42%> (-7.25%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.85% <0.00%> (-0.67%) ⬇️
src/RestWrite.js 93.51% <0.00%> (-0.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0a9c70...4eb7b84. Read the comment docs.

@SebC99
Copy link
Contributor Author

SebC99 commented Jul 5, 2020

@acinader @dplewis any idea what kind of test should I add to increase the coverage?

Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SebC99 Thanks for tackling this. I believe it is fine as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants