Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Node 10 support (EOL) #7314

Merged
merged 4 commits into from
Apr 2, 2021
Merged

Remove Node 10 support (EOL) #7314

merged 4 commits into from
Apr 2, 2021

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Apr 2, 2021 •
edited
Loading

New Pull Request Checklist

Issue Description

Node 10 reached its EOL support date in April 2021.

Related issue: (n/a, meta)

Approach

Node 10 is removed from official Parse Server support.
This reduces the number of CI test by 1.

TODOs before merging

  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@codecov
Copy link

codecov bot commented Apr 2, 2021 •
edited
Loading

Codecov Report

Merging #7314 (d97fa08) into master (626352d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head d97fa08 differs from pull request most recent head d276a90. Consider uploading reports for the commit d276a90 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7314   +/-   ##
=======================================
  Coverage   93.89%   93.89%           
=======================================
  Files         181      181           
  Lines       13190    13193    +3     
=======================================
+ Hits        12385    12388    +3     
  Misses        805      805
Impacted Files Coverage Δ
src/Routers/FilesRouter.js 88.54% <100.00%> (+0.26%) ⬆️
src/batch.js 91.37% <0.00%> (-1.73%) ⬇️
src/ParseServerRESTController.js 97.01% <0.00%> (-1.50%) ⬇️
src/RestWrite.js 93.84% <0.00%> (+0.16%) ⬆️
src/Adapters/Files/GridFSBucketAdapter.js 80.32% <0.00%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 626352d...d276a90. Read the comment docs.

@mtrezza mtrezza requested review from davimacedo and dplewis April 2, 2021 14:21
@mtrezza mtrezza merged commit 70e1347 into parse-community:master Apr 2, 2021
Arul- pushed a commit to Arul-/parse-server that referenced this pull request Apr 4, 2021
@mtrezza @Arul-
Remove Node 10 support (EOL) (parse-community#7314)
24baffc 
* removed node 10 support (EOL)

* added changelog entry

* updated CI check

* updated babel env preset to node 12
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Nov 1, 2021
@mtrezza mtrezza mentioned this pull request Mar 12, 2022
Merged
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 14, 2022
@mtrezza mtrezza deleted the remove-Node-10-support branch March 24, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davimacedo davimacedo davimacedo approved these changes

@dplewis dplewis Awaiting requested review from dplewis

Assignees
No one assigned
Labels
state:released Released as stable version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtrezza @parseplatformorg @davimacedo