Remove MongoDB 3.6 support (EOL) #7315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7315 +/- ##
==========================================
- Coverage 93.57% 86.26% -7.31%
==========================================
Files 181 181
Lines 13193 13193
==========================================
- Hits 12345 11381 -964
- Misses 848 1812 +964
Continue to review full report at Codecov.
|
I believe that test can be removed |
|
Well, MMAP is deprecated from 4.0 but only removed in 4.2., so we would essentially cut off the deprecation period that MongoDB provides by 1 year. We couldn't say anymore that Parse Server is fully compatible with MongoDB 4.0 because we would remove partial support for MongoDB 4.0. Then there is the standalone aspect - this is the only test that runs against a standalone DB instance. |
|
@dplewis If you are fine with #7315 (comment) I'll merge this later today. @davimacedo any opinion on this? |
davimacedo
approved these changes
Apr 7, 2021
mtrezza
added a commit
that referenced
this pull request
Apr 8, 2021
* bumped MongoDB to 4.4.5 * bump Node to 14.16.1 * removed obsolete COVERAGE_OPTION * improved postges support note * bump more node * Remove MongoDB 3.6 support (EOL) (#7315) * removed mongodb 3.6 support * add changelog entry * updated CI check * bumped MongoDB to 4.4.5 * bump Node to 14.16.1 * removed obsolete COVERAGE_OPTION * improved postges support note * bump more node * updated package lock * Revert "bumped MongoDB to 4.4.5" This reverts commit ce9c810. * skipping MongoDB 4.4.5 temporarily * fixed bug in CI check that did not consider ignored versions when checking for newer versions * removed Postgres 10 support * updated Postgres versions * renamed MongoDB CI tests * fixed Postgres compatibility table * fix Postgres badge
mtrezza
added a commit
that referenced
this pull request
Apr 8, 2021
* fix: upgrade mongodb from 3.6.3 to 3.6.5 Snyk has created this PR to upgrade mongodb from 3.6.3 to 3.6.5. See this package in npm: https://www.npmjs.com/package/mongodb See this project in Snyk: https://app.snyk.io/org/acinader/project/8c1a9edb-c8f5-4dc1-b221-4d6030a323eb?utm_source=github&utm_medium=upgrade-pr * bump mongo 3.6.6 * update package-lock * updated package-lock * fix: upgrade winston-daily-rotate-file from 4.5.0 to 4.5.1 (#7309) Snyk has created this PR to upgrade winston-daily-rotate-file from 4.5.0 to 4.5.1. See this package in npm: https://www.npmjs.com/package/winston-daily-rotate-file See this project in Snyk: https://app.snyk.io/org/acinader/project/8c1a9edb-c8f5-4dc1-b221-4d6030a323eb?utm_source=github&utm_medium=upgrade-pr * Bump CI environment, remove Postgres 10 support (#7323) * bumped MongoDB to 4.4.5 * bump Node to 14.16.1 * removed obsolete COVERAGE_OPTION * improved postges support note * bump more node * Remove MongoDB 3.6 support (EOL) (#7315) * removed mongodb 3.6 support * add changelog entry * updated CI check * bumped MongoDB to 4.4.5 * bump Node to 14.16.1 * removed obsolete COVERAGE_OPTION * improved postges support note * bump more node * updated package lock * Revert "bumped MongoDB to 4.4.5" This reverts commit ce9c810. * skipping MongoDB 4.4.5 temporarily * fixed bug in CI check that did not consider ignored versions when checking for newer versions * removed Postgres 10 support * updated Postgres versions * renamed MongoDB CI tests * fixed Postgres compatibility table * fix Postgres badge * Add deprecation policy (#7199) * added phased deprecation policy * fixed typo * added changelog entry * some rewording * Fixed typo * fixed typo * Fixed typo * updated deprecation policy * remove empty line * fix: upgrade mongodb from 3.6.3 to 3.6.5 Snyk has created this PR to upgrade mongodb from 3.6.3 to 3.6.5. See this package in npm: https://www.npmjs.com/package/mongodb See this project in Snyk: https://app.snyk.io/org/acinader/project/8c1a9edb-c8f5-4dc1-b221-4d6030a323eb?utm_source=github&utm_medium=upgrade-pr * bump mongo 3.6.6 * Update package-lock.json Co-authored-by: Manuel Trezza <[email protected]>
Arul-
pushed a commit
to Arul-/parse-server
that referenced
this pull request
Apr 12, 2021
* removed mongodb 3.6 support * add changelog entry * updated CI check
Arul-
pushed a commit
to Arul-/parse-server
that referenced
this pull request
Apr 12, 2021
* bumped MongoDB to 4.4.5 * bump Node to 14.16.1 * removed obsolete COVERAGE_OPTION * improved postges support note * bump more node * Remove MongoDB 3.6 support (EOL) (parse-community#7315) * removed mongodb 3.6 support * add changelog entry * updated CI check * bumped MongoDB to 4.4.5 * bump Node to 14.16.1 * removed obsolete COVERAGE_OPTION * improved postges support note * bump more node * updated package lock * Revert "bumped MongoDB to 4.4.5" This reverts commit ce9c810. * skipping MongoDB 4.4.5 temporarily * fixed bug in CI check that did not consider ignored versions when checking for newer versions * removed Postgres 10 support * updated Postgres versions * renamed MongoDB CI tests * fixed Postgres compatibility table * fix Postgres badge
Arul-
pushed a commit
to Arul-/parse-server
that referenced
this pull request
Apr 12, 2021
* fix: upgrade mongodb from 3.6.3 to 3.6.5 Snyk has created this PR to upgrade mongodb from 3.6.3 to 3.6.5. See this package in npm: https://www.npmjs.com/package/mongodb See this project in Snyk: https://app.snyk.io/org/acinader/project/8c1a9edb-c8f5-4dc1-b221-4d6030a323eb?utm_source=github&utm_medium=upgrade-pr * bump mongo 3.6.6 * update package-lock * updated package-lock * fix: upgrade winston-daily-rotate-file from 4.5.0 to 4.5.1 (parse-community#7309) Snyk has created this PR to upgrade winston-daily-rotate-file from 4.5.0 to 4.5.1. See this package in npm: https://www.npmjs.com/package/winston-daily-rotate-file See this project in Snyk: https://app.snyk.io/org/acinader/project/8c1a9edb-c8f5-4dc1-b221-4d6030a323eb?utm_source=github&utm_medium=upgrade-pr * Bump CI environment, remove Postgres 10 support (parse-community#7323) * bumped MongoDB to 4.4.5 * bump Node to 14.16.1 * removed obsolete COVERAGE_OPTION * improved postges support note * bump more node * Remove MongoDB 3.6 support (EOL) (parse-community#7315) * removed mongodb 3.6 support * add changelog entry * updated CI check * bumped MongoDB to 4.4.5 * bump Node to 14.16.1 * removed obsolete COVERAGE_OPTION * improved postges support note * bump more node * updated package lock * Revert "bumped MongoDB to 4.4.5" This reverts commit ce9c810. * skipping MongoDB 4.4.5 temporarily * fixed bug in CI check that did not consider ignored versions when checking for newer versions * removed Postgres 10 support * updated Postgres versions * renamed MongoDB CI tests * fixed Postgres compatibility table * fix Postgres badge * Add deprecation policy (parse-community#7199) * added phased deprecation policy * fixed typo * added changelog entry * some rewording * Fixed typo * fixed typo * Fixed typo * updated deprecation policy * remove empty line * fix: upgrade mongodb from 3.6.3 to 3.6.5 Snyk has created this PR to upgrade mongodb from 3.6.3 to 3.6.5. See this package in npm: https://www.npmjs.com/package/mongodb See this project in Snyk: https://app.snyk.io/org/acinader/project/8c1a9edb-c8f5-4dc1-b221-4d6030a323eb?utm_source=github&utm_medium=upgrade-pr * bump mongo 3.6.6 * Update package-lock.json Co-authored-by: Manuel Trezza <[email protected]>
|
🎉 This change has been released in version 5.0.0-beta.1 |
Merged
|
🎉 This change has been released in version 5.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
MongoDB 3.6 reached its EOL support date in April 2021.
Related issue: (n/a, meta)
Approach
MongoDB 3.6 support is removed from official Parse Server support.
This does not reduce the number of CI tests, because it was the only test with MMAPv1 engine and standalone topology. Consequently, that test now runs with MongoDB 4.0.
TODOs before merging