Add esomx, trackerm, p2 + eliminate duplicated data so new hardware platforms can easily be added #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 2, 2022 18:14
When eliminating hard-coded tags and using device-constant platform features instead, the following changes we're observed p2: has "som" tag, when it shouldn't, eliminated. tracker: had "gps" before, now has "gnss", no integration tests use this so no breaking changes b5som,bsom,boron,argon: all now also have "mesh" tag
joegoggins
force-pushed
the
sc-98440/make-platforms-depend-on-device-constants
branch
from
0e2c085 to
55b7eb5
Compare
joegoggins
changed the title
|
Thanks for the reviews folks. Now that this is merged, I'm going to do a bit of tidying up to eliminate the 3 WIP PRs on this project via sc-104576 and then (after PR reviews/updates/merging) will cut 0.5.0. Sergey and I synced about this gameplan privately last week, but figured I'd drop it here in case Mirande wants to chime in/make recommendations/etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds support for
esomxandtrackermplatforms. Also adjusts code so that future hardware platforms will not require custom modifications, but rather, just a simple update of@particle/device-constantsversion and a re-release.The approach to eliminating duplicated hardware platform
tagsmetadata was to depend on device-constantsfeaturesdata directly and transforming the data slightly to comply with the internal data structures in platform.js.See sc-98440 for more details.
How to test?
Observe the new unit tests that cover the expected tags for each platform. Some of these tags are used in DVOS integration tests here: https://github.com/particle-iot/device-os/tree/develop/user/tests/integration
git checkout sc-98440/make-platforms-depend-on-device-constantsnpm inpm testObserve that
esomx,trackerm, andp2args can be passed to a build command like this: (you'll need to modify the args to match actual location of device-os on your machine)This command should fail in way that clearly illustrates that the
esomxarg was accepted and that themakesystem of device-os got executed. Instead ofError: Unrecognized filtering option: bonk, you should see something like this: