-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GCC plugin integration #1385
Open
sergeuz
wants to merge
9
commits into
develop
Choose a base branch
from
feature/logging2
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
GCC plugin integration #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssible errors when a C++ template is specialized after it has been instantiated already
… available at compile time
…f the root makefiles
…t for building the plugin
74ede32
to
7518650
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The GCC plugin needs to be integrated with our build system in order to update firmware message files during the build.
The firmware should be able to expand its own logging based on message IDs.
Solution
Update makefiles to invoke the plugin for every source file that is being compiled.
Provide a tool to convert a message file to a source file containing log messages data. Update formatter classes to perform a lookup in the log messages data for every message based on its ID.
Steps to Test
Build the system firmware.
Invoke the
update-msg
tool to generate a source file with the log messages data in the application directory.Example App
N/A
References
update-msg
tool: https://github.com/sergeuz/particle-update-msgCompleteness