[gen3] fix internal -> external flash writes #2843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gned_and_unaligned_writes_from_internal_flash_work. coalesce gen3/gen4 flash_common implementation
Merged
…ymbols from COMMON section, which are essentially .bss
scott-brust
approved these changes
Dec 4, 2024
| @@ -172,3 +205,17 @@ test(EXFLASH_02_rtl872x_validate_mode) { | |||
| assertEqual((uint32_t)SPIC->baudr, (uint32_t)1); | |||
| } | |||
| #endif // HAL_PLATFORM_RTL872X | |||
|
|
|||
| test(EXFLASH_03_aligned_and_unaligned_writes_from_internal_flash_work) { | |||
There was a problem hiding this comment.
What part of this test is from_internal_flash? Does gen3 execute this code as XIP?
hal_storage_write() is the external OTA flash section for both platforms right?
There was a problem hiding this comment.
static uint8_t dummy[8192 + 4] __attribute((aligned(4))) = {0xff, 0xff, 0xff, 0xff}; is internal on gen 3, RAM on Gen 4, but the test is still kind of valid for gen 4.
There was a problem hiding this comment.
Oops, that needs to be static const now that you mention it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
External flash writes must be performed from RAM and can't be done directly from internal flash due to DMA requirements.
Solution
If data address is not in RAM, force
hal_flash_common_writeto perform writes through an intermediate 256 byte on-stack aligned buffer.Steps to Test
Example App
N/A
References
#2840
Completeness