Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gen4] wifi: use BSSID from scan result, always perform scans before connect #2849

Conversation

avtolstoy
Copy link
Member

@avtolstoy avtolstoy commented Dec 11, 2024

Description

Default connect sequence in RTL872x SDK doesn't seem to work well with single SSID/multiple BSSIDs, apply the same workaround as for ESP32-based platforms to always perform a scan and use the best access point (BSSID) based on signal strength to connect to, instead of just blindly letting the SDK to connect by SSID name.

(I2C log change is unrelated, just fixing an annoying log line that can occur with flaky I2C buses or devices that like to NACK a lot)

Steps to Test

Which unit/integration/application tests are applicable to this code change? (At minimum a test of some kind should be provided)

Example App

N/A

References

N/A

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@avtolstoy avtolstoy added this to the 6.2.1 milestone Dec 11, 2024
@avtolstoy avtolstoy requested a review from technobly December 11, 2024 18:28
Copy link
Member

@technobly technobly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avtolstoy avtolstoy merged commit 2d8e71e into develop Dec 11, 2024
13 checks passed
@avtolstoy avtolstoy deleted the feature/rtl872x-always-scan-and-connect-to-scan-result-bssid branch December 11, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants