Fix section size calc for some filenames #2852
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 38ced0d introduced alignment into section size calculations, but failed on file paths that contain strings "data", "bss", etc. Apply a small fix to the Makefile macro. Bug report: https://community.particle.io/t/section-bss-will-not-fit-in-region-sram/66641
avtolstoy
approved these changes
Jan 9, 2025
|
Thanks! I'll get this in for the next release. |
|
Merged in 872bf0a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Commit 38ced0d introduced alignment into section size calculations, but failed on file paths that contain strings "data", "bss", etc.
Solution
Apply a small fix to the Makefile macro.
Steps to Test
Create a project or file path containing the string "data".
Example App
N/A
References
Bug report:
https://community.particle.io/t/section-bss-will-not-fit-in-region-sram/66641
Completeness