Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wiring] implement WiFi/Cellular/Ethernet/Network.ping() for Gen 3 and Gen 4 platforms #2856

Merged
merged 4 commits into from
Jan 23, 2025

Conversation

avtolstoy
Copy link
Member

Problem

WiFi/Cellular/Ethernet/Network``.ping() is not implement for Gen 3 and Gen 4 platforms.

Steps to Test

  • wiring/api
  • wiring/no_fixture_wifi
  • wiring/no_fixture_cellular
  • wiring/network_config (for Ethernet)

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@avtolstoy avtolstoy added this to the 6.3.0 milestone Jan 23, 2025
@avtolstoy avtolstoy requested a review from scott-brust January 23, 2025 11:21
@avtolstoy avtolstoy force-pushed the feature/network-ping branch from c5348af to 8aa7fd7 Compare January 23, 2025 18:32
@avtolstoy avtolstoy merged commit 862a459 into develop Jan 23, 2025
2 of 12 checks passed
@avtolstoy avtolstoy deleted the feature/network-ping branch January 23, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants