Skip to content

Commit

Permalink
fix(loki): workaround targetdown alert for loki-gateway (#3043)
Browse files Browse the repository at this point in the history
We wouldn't get much details from nginx anyway as the pod is nginx OSS,
so let's forget about metrics for this component

Ref: grafana/loki#9522 (comment)

Signed-off-by: Thomas P. <[email protected]>
  • Loading branch information
TPXP authored Oct 18, 2024
1 parent a00c3b9 commit 88de877
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 0 deletions.
4 changes: 4 additions & 0 deletions loki-stack.tf
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ locals {
priorityClassName: ${local.priority-class["create"] ? kubernetes_priority_class.kubernetes_addons[0].metadata[0].name : ""}
serviceMonitor:
enabled: ${local.kube-prometheus-stack["enabled"] || local.victoria-metrics-k8s-stack["enabled"]}
gateway:
service:
labels:
prometheus.io/service-monitor: "false"
VALUES
}

Expand Down
4 changes: 4 additions & 0 deletions modules/aws/loki-stack.tf
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ locals {
enabled: false
serviceMonitor:
enabled: ${local.kube-prometheus-stack["enabled"] || local.victoria-metrics-k8s-stack["enabled"]}
gateway:
service:
labels:
prometheus.io/service-monitor: "false"
priorityClassName: ${local.priority-class["create"] ? kubernetes_priority_class.kubernetes_addons[0].metadata[0].name : ""}
serviceAccount:
name: ${local.loki-stack["name"]}
Expand Down
4 changes: 4 additions & 0 deletions modules/google/loki-stack.tf
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ locals {
enabled: false
serviceMonitor:
enabled: ${local.kube-prometheus-stack["enabled"] || local.victoria-metrics-k8s-stack["enabled"]}
gateway:
service:
labels:
prometheus.io/service-monitor: "false"
priorityClassName: ${local.priority-class["create"] ? kubernetes_priority_class.kubernetes_addons[0].metadata[0].name : ""}
serviceAccount:
create: false
Expand Down
4 changes: 4 additions & 0 deletions modules/scaleway/loki-stack.tf
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ locals {
dnsService: coredns
serviceMonitor:
enabled: ${local.kube-prometheus-stack["enabled"] || local.victoria-metrics-k8s-stack["enabled"]}
gateway:
service:
labels:
prometheus.io/service-monitor: "false"
priorityClassName: ${local.priority-class["create"] ? kubernetes_priority_class.kubernetes_addons[0].metadata[0].name : ""}
persistence:
enabled: true
Expand Down

0 comments on commit 88de877

Please sign in to comment.