feat: Adding optional kms key id to encrypt cw log group for fluent bit #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zestrells
requested review from
ArchiFleKs and
rguichard
and removed request for
a team
|
I am not sure if this should be an empty string, or if it should be set to null for the |
|
After digging more into it, setting null defaults to the default var being set which is the correct behavior we want. |
ArchiFleKs
approved these changes
Oct 15, 2022
|
Hi @ArchiFleKs , I noticed this did not create a release version and can only use this change with main branch. Can we get this into a release version please? |
|
🎉 This PR is included in version 11.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding optional kms key id to encrypt cw log group for fluent bit
Description
Adding optional kms key id to encrypt cw log group for fluent bit
Checklist