Update Interner from hashbrown 0.14 to 0.15 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
Byron
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Thanks a lot for contributing this upgrade, it's much appreciated!
I have additionally run this PR against the gitoxide test suite (diff and merge) and everything works like one would expect.
On top of that, I ran it against GitButler, which seemed to have received a 15% performance boost. It was an instruments run, so there may be fluctuations, but I'd call it a good sign at least.
Merging and a new release would be appreciated.
|
Thank you! I am definitely looking forward to the new release, I think it will improve performance measurably. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes: https://github.com/rust-lang/hashbrown/blob/master/CHANGELOG.md
RawTableis no longer available in this release, in favor of recommending theHashTableAPI instead.