Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Matrix precision and use no_grad in adjoint #126

Merged
merged 5 commits into from
Nov 9, 2023
Merged

[Fix] Matrix precision and use no_grad in adjoint #126

merged 5 commits into from
Nov 9, 2023

Conversation

dominikandreasseitz
Copy link
Collaborator

@dominikandreasseitz dominikandreasseitz commented Nov 7, 2023 •
edited
Loading

Added missing dtype to matrix inits which causes issues in qadence. added no_grad decorator to first order adjoint, bump version

@dominikandreasseitz dominikandreasseitz changed the title Use no_grad in adjoint [Fix] Matrix precision and use no_grad in adjoint Nov 9, 2023
RolandMacDoland
RolandMacDoland approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@RolandMacDoland RolandMacDoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@dominikandreasseitz dominikandreasseitz merged commit da11186 into main Nov 9, 2023
@dominikandreasseitz dominikandreasseitz deleted the ds/no_grad branch November 9, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RolandMacDoland RolandMacDoland RolandMacDoland approved these changes

@jpmoutinho jpmoutinho jpmoutinho approved these changes

Assignees

@dominikandreasseitz dominikandreasseitz

@jpmoutinho jpmoutinho

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dominikandreasseitz @RolandMacDoland @jpmoutinho