Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs / Fix] Add documentation + Correct GPU Device inference #135

Merged
merged 18 commits into from
Feb 1, 2024
Merged

[Docs / Fix] Add documentation + Correct GPU Device inference #135

merged 18 commits into from
Feb 1, 2024

Conversation

dominikandreasseitz
Copy link
Collaborator

  • Remake of pyq gates into pure torch.nn.Modules enables automatic moving of buffers to device.
  • Adding a custom 'to' method to QuantumCircuit since without it, the gates are not moved to the device

@dominikandreasseitz dominikandreasseitz added the bug Something isn't working label Jan 31, 2024
@dominikandreasseitz dominikandreasseitz self-assigned this Jan 31, 2024
@dominikandreasseitz dominikandreasseitz changed the title [Fix] Device inference [Fix] Correct GPU Device inference Jan 31, 2024
@dominikandreasseitz dominikandreasseitz mentioned this pull request Jan 31, 2024
Merged
awennersteen
awennersteen reviewed Jan 31, 2024
View reviewed changes
pyqtorch/circuit.py Outdated Show resolved Hide resolved
awennersteen
awennersteen reviewed Jan 31, 2024
View reviewed changes
pyqtorch/circuit.py Outdated Show resolved Hide resolved
@dominikandreasseitz dominikandreasseitz changed the title [Fix] Correct GPU Device inference [Docs / Fix] Add documentation + Correct GPU Device inference Feb 1, 2024
awennersteen
awennersteen reviewed Feb 1, 2024
View reviewed changes
docs/index.md Show resolved Hide resolved
pyqtorch/circuit.py Outdated Show resolved Hide resolved
tests/test_circuit.py Show resolved Hide resolved
awennersteen
awennersteen approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@awennersteen awennersteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Up to you what you think is better with the function

@dominikandreasseitz dominikandreasseitz merged commit e5928a7 into main Feb 1, 2024
6 checks passed
@dominikandreasseitz dominikandreasseitz deleted the ds/fix_device branch February 1, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awennersteen awennersteen awennersteen approved these changes

@jpmoutinho jpmoutinho Awaiting requested review from jpmoutinho

Assignees

@dominikandreasseitz dominikandreasseitz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dominikandreasseitz @awennersteen