Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Debug logging and NVTX annotations #144

Merged
merged 8 commits into from
May 28, 2024
Merged

[Feature] Debug logging and NVTX annotations #144

merged 8 commits into from
May 28, 2024

Conversation

awennersteen
Copy link
Member

@awennersteen awennersteen commented Mar 7, 2024 •
edited by RolandMacDoland
Loading

Closes #166

@dominikandreasseitz
Copy link
Collaborator

thanks @awennersteen , have you tested it in conjunction with qadence?

dominikandreasseitz
dominikandreasseitz approved these changes Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@dominikandreasseitz dominikandreasseitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, would be nice to see how the logs actually look like for a standard usecase

@RolandMacDoland RolandMacDoland changed the title [FEAT] Debug logging and NVTX annotations [Feature] Debug logging and NVTX annotations Apr 26, 2024
@RolandMacDoland RolandMacDoland added the feature New feature or request label Apr 26, 2024
awennersteen
awennersteen commented May 15, 2024
View reviewed changes
pyqtorch/primitive.py Outdated Show resolved Hide resolved
@dominikandreasseitz dominikandreasseitz merged commit 34513ff into main May 28, 2024
9 checks passed
@dominikandreasseitz dominikandreasseitz deleted the aw/logging branch May 28, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikandreasseitz dominikandreasseitz dominikandreasseitz approved these changes

Assignees

@awennersteen awennersteen

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Debug logging and NVTX annotations
3 participants
@awennersteen @dominikandreasseitz @RolandMacDoland