Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add local RZ gate for pulser backend #114

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Add local RZ gate for pulser backend #114

merged 2 commits into from
Oct 23, 2023

Conversation

vytautas-a
Copy link
Collaborator

Implement local RZ gate for Pulser backend.

Closes #41

@vytautas-a vytautas-a self-assigned this Oct 18, 2023
@vytautas-a vytautas-a requested a review from madagra October 18, 2023 13:27
@madagra madagra added feature New feature or request core-dev labels Oct 19, 2023
madagra
madagra reviewed Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@madagra madagra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of quick comments but it looks overall good to me.

qadence/backends/pulser/pulses.py Show resolved Hide resolved
qadence/backends/pulser/pulses.py Show resolved Hide resolved
madagra
madagra approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@madagra madagra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @vytautas-a. It looks good to me now.

@vytautas-a vytautas-a merged commit e21fdf0 into main Oct 23, 2023
7 checks passed
@vytautas-a vytautas-a deleted the va/rz-gate-pulser branch October 23, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madagra madagra madagra approved these changes

Assignees

@vytautas-a vytautas-a

Labels
core-dev feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add local RZ gate to the Pulser backend
2 participants
@vytautas-a @madagra