Correctly draw analog blocks; improve HamEvo drawings #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Indeed, looks nice. Thanks for this ! |
|
Question @nmheim , why is the last one shaded ? I.e. before the swaps. Is this because it is the observable to be measured ? |
Good point, I initially wanted to shade non hermitian blocks. But then when implementing the analog ones used the same draw logic. What do you thing about only shading scale/add blocks and remove it for hamevo/anslog? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note the analog blocks. the first analog block is large enough to have all the text in multiple lines. the second one is too small so we plot everything on one line.