-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Implement constructor function for alternating layer ansatz #565
Merged
chMoussa
merged 24 commits into
pasqal-io:main
from
ducthanh1991:feature/digital_alternating_layer_ansatz_function
Sep 23, 2024
Merged
[Feature] Implement constructor function for alternating layer ansatz #565
chMoussa
merged 24 commits into
pasqal-io:main
from
ducthanh1991:feature/digital_alternating_layer_ansatz_function
Sep 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttps://github.com/ducthanh1991/qadence into feature/digital_alternating_layer_ansatz_function
Thanks a lot! We might take a couple of days to review properly due to slightly busy period, and some holidays being taken on top of that |
RolandMacDoland
assigned RolandMacDoland and ducthanh1991 and unassigned RolandMacDoland
Sep 12, 2024
chMoussa
requested changes
Sep 16, 2024
ducthanh1991
commented
Sep 19, 2024
chMoussa
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! LGTM, thanks @ducthanh1991
This was referenced Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposition of resolution of #532: Implementation of a constructors function that create a Alternating Layer Ansatz circuit.
Done:
Example of an alt circuit generated with the function for
n_qubits=10,m_qubits_block=4,depth=2
To do: