Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Resume dictdataloader support for Trainer #627

Merged
merged 7 commits into from
Dec 5, 2024
Merged

[bug] Resume dictdataloader support for Trainer #627

merged 7 commits into from
Dec 5, 2024

Conversation

mlahariya
Copy link
Collaborator

No description provided.

@mlahariya mlahariya self-assigned this Dec 5, 2024
chMoussa
chMoussa reviewed Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@chMoussa chMoussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mlahariya, thanks for fixing this. Let us also do an extra test to check one can train on a simple example with a dictdataloader as input

qadence/ml_tools/train_utils/base_trainer.py Outdated Show resolved Hide resolved
qadence/ml_tools/train_utils/base_trainer.py Outdated Show resolved Hide resolved
chMoussa
chMoussa approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@chMoussa chMoussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do you think there is a need to add more docs on it?

@mlahariya
Copy link
Collaborator Author

LGTM, do you think there is a need to add more docs on it?

In the API documentation the dictdataloader support is already documented.
We should definately add an example of using the dictdataloader with trainer - but I am not sure which example would be most relevant. So for now we can skip it, and create a issue for it to be added later on.

RolandMacDoland
RolandMacDoland approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@RolandMacDoland RolandMacDoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! Thanks a lot @mlahariya.

qadence/ml_tools/callbacks/writer_registry.py Show resolved Hide resolved
@mlahariya mlahariya merged commit ad4051b into main Dec 5, 2024
8 checks passed
@mlahariya mlahariya deleted the ML_03122024 branch December 5, 2024 13:07
@mlahariya mlahariya restored the ML_03122024 branch December 5, 2024 13:50
@mlahariya mlahariya deleted the ML_03122024 branch December 5, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RolandMacDoland RolandMacDoland RolandMacDoland approved these changes

@chMoussa chMoussa chMoussa approved these changes

Assignees

@mlahariya mlahariya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mlahariya @RolandMacDoland @chMoussa