Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-28109) chore(ESLint): add rule to avoid use of .sort #5994

Closed

Conversation

voisinhugo
Copy link

Copy link

github-actions bot commented Feb 21, 2024

Performance Comparison Report

Significant Changes To Render Duration

There are no entries

Meaningless Changes To Render Duration

Show entries
Name Render Duration Render Count
Performance test for Offer page 330.1 ms → 333.2 ms (+3.1 ms, +0.9%) 9 → 9
Performance test for Favorites page 55.7 ms → 58.1 ms (+2.4 ms, +4.3%) 6 → 6
Search Landing Page - Performance test for Search Landing page 94.2 ms → 95.6 ms (+1.4 ms, +1.5%) 8 → 8
Search Results - Performance test for Search Results page 93.1 ms → 93.9 ms (+0.8 ms, +0.9%) 8 → 8
Performance test for EndedBookings page 21.6 ms → 22.1 ms (+0.5 ms, +2.3%) 7 → 7
Performance test for Bookings page 37.2 ms → 37.1 ms (-0.1 ms, ±0.0%) 8 → 8
Performance test for Profile page 91.8 ms → 91.1 ms (-0.7 ms, -0.8%) 8 → 8
Performance test for Venue page 322.9 ms → 320.3 ms (-2.6 ms, -0.8%) 8 → 8
Show details
Name Render Duration Render Count
Performance test for Offer page Baseline
Mean: 330.1 ms
Stdev: 11.2 ms (3.4%)
Runs: 357 335 333 332 331 329 325 321 321 317

Current
Mean: 333.2 ms
Stdev: 12.2 ms (3.6%)
Runs: 359 342 338 336 335 334 328 321 320 319
Baseline
Mean: 9
Stdev: 0 (0.0%)
Runs: 9 9 9 9 9 9 9 9 9 9

Current
Mean: 9
Stdev: 0 (0.0%)
Runs: 9 9 9 9 9 9 9 9 9 9
Performance test for Favorites page Baseline
Mean: 55.7 ms
Stdev: 2.0 ms (3.6%)
Runs: 60 57 57 56 56 55 55 54 54 53

Current
Mean: 58.1 ms
Stdev: 1.0 ms (1.7%)
Runs: 60 59 59 58 58 58 58 57 57 57
Baseline
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6

Current
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6
Search Landing Page - Performance test for Search Landing page Baseline
Mean: 94.2 ms
Stdev: 2.3 ms (2.5%)
Runs: 98 98 95 95 94 93 93 93 92 91

Current
Mean: 95.6 ms
Stdev: 2.7 ms (2.8%)
Runs: 99 99 97 96 96 96 96 94 93 90
Baseline
Mean: 8
Stdev: 0 (0.0%)
Runs: 8 8 8 8 8 8 8 8 8 8

Current
Mean: 8
Stdev: 0 (0.0%)
Runs: 8 8 8 8 8 8 8 8 8 8
Search Results - Performance test for Search Results page Baseline
Mean: 93.1 ms
Stdev: 3.5 ms (3.7%)
Runs: 97 97 96 95 95 93 92 90 88 88

Current
Mean: 93.9 ms
Stdev: 3.3 ms (3.6%)
Runs: 101 97 96 95 93 92 92 92 91 90
Baseline
Mean: 8
Stdev: 0 (0.0%)
Runs: 8 8 8 8 8 8 8 8 8 8

Current
Mean: 8
Stdev: 0 (0.0%)
Runs: 8 8 8 8 8 8 8 8 8 8
Performance test for EndedBookings page Baseline
Mean: 21.6 ms
Stdev: 1.4 ms (6.6%)
Runs: 23 23 23 23 22 21 21 21 20 19

Current
Mean: 22.1 ms
Stdev: 1.7 ms (7.5%)
Runs: 24 24 23 23 23 23 21 20 20 20
Baseline
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7

Current
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
Performance test for Bookings page Baseline
Mean: 37.2 ms
Stdev: 1.8 ms (4.7%)
Runs: 39 39 39 38 38 37 37 36 35 34

Current
Mean: 37.1 ms
Stdev: 2.2 ms (5.9%)
Runs: 40 39 38 38 38 37 37 36 36 32
Baseline
Mean: 8
Stdev: 0 (0.0%)
Runs: 8 8 8 8 8 8 8 8 8 8

Current
Mean: 8
Stdev: 0 (0.0%)
Runs: 8 8 8 8 8 8 8 8 8 8
Performance test for Profile page Baseline
Mean: 91.8 ms
Stdev: 2.3 ms (2.5%)
Runs: 95 94 94 93 92 92 91 90 89 88

Current
Mean: 91.1 ms
Stdev: 3.0 ms (3.3%)
Runs: 96 93 93 93 92 91 90 89 89 85
Baseline
Mean: 8
Stdev: 0 (0.0%)
Runs: 8 8 8 8 8 8 8 8 8 8

Current
Mean: 8
Stdev: 0 (0.0%)
Runs: 8 8 8 8 8 8 8 8 8 8
Performance test for Venue page Baseline
Mean: 322.9 ms
Stdev: 7.5 ms (2.3%)
Runs: 334 334 326 325 324 322 321 317 315 311

Current
Mean: 320.3 ms
Stdev: 9.4 ms (2.9%)
Runs: 338 333 326 318 318 317 317 317 312 307
Baseline
Mean: 8
Stdev: 0 (0.0%)
Runs: 8 8 8 8 8 8 8 8 8 8

Current
Mean: 8
Stdev: 0 (0.0%)
Runs: 8 8 8 8 8 8 8 8 8 8

Changes To Render Count

There are no entries

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against 99da1ae

@voisinhugo voisinhugo force-pushed the PC-28109-add-eslint-rule-to-avoid-use-of-sort branch from dc59dd1 to 3fae8aa Compare February 21, 2024 13:25
@voisinhugo voisinhugo force-pushed the PC-28109-add-eslint-rule-to-avoid-use-of-sort branch from e10fba1 to 44c44ba Compare February 21, 2024 15:17
@voisinhugo
Copy link
Author

Hermes ne supporte pas encore .toSorted() : facebook/hermes#1298

@voisinhugo voisinhugo closed this Feb 21, 2024
@voisinhugo voisinhugo reopened this Feb 29, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
81.8% Coverage on New Code (required ≥ 85%)

See analysis details on SonarCloud

@voisinhugo
Copy link
Author

polyfill was breaking on React-Native, I don't really know how to proceed…

@voisinhugo voisinhugo closed this Mar 8, 2024
@bebstein-pass bebstein-pass deleted the PC-28109-add-eslint-rule-to-avoid-use-of-sort branch July 31, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant