(BSR) refactor(SettingsContext): add setSettings for tests #7581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlecunff-pass
force-pushed
the
remove-settings-context
branch
2 times, most recently
from
2498384 to
d247370
Compare
xlecunff-pass
changed the title
xlecunff-pass
force-pushed
the
remove-settings-context
branch
from
3c87701 to
ca6fad4
Compare
xlecunff-pass
force-pushed
the
remove-settings-context
branch
from
ca6fad4 to
4e438a2
Compare
cgerrard-pass
approved these changes
Jan 28, 2025
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
L'objectif final est de supprimer le SettingContext, la première brique de se travail est d'abstraire le mock des settings dans une fonction qui sera appelée au besoin:
setSettingsL'app a des FF venant du backend et de firebase, j'ai réutilisé la logique de
setFeatureFlagpour créersetSettingsJ'ai un petit doute sur le naming car setSettings est aussi une fonction d'Algolia, qui est autocomplétée et mise avant ce setSettings