This repository has been archived by the owner on Sep 29, 2024. It is now read-only.
Address concerns from Guido Vranken fuzzers #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enforce prefix boundaries on initialization.
|
@guidovranken good to merge? |
| NSLog(@"Can't partition single IPv6"); | ||
| return @[self, self]; | ||
| } | ||
|
|
||
| struct in6_addr saddr1, saddr2; | ||
| char addr[INET6_ADDRSTRLEN]; | ||
| NSData *addressData = RoutingTableEntryAddress6(self.network); |
There was a problem hiding this comment.
NULL check of addressData?
if ( addressData == NULL ) return NULL;
There was a problem hiding this comment.
Also NULL checks after calls to RoutingTableEntryAddress6 in matchesDestination. At least in my fuzzers I observe crashes if those checks are not there.
RoutingTableEntryAddress4 calls might need similar checks.
After addressing my remarks about RoutingTableEntry.m, yes. |
|
Those |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.