This repository has been archived by the owner on Sep 29, 2024. It is now read-only.
Delegate network settings to ad-hoc builder #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keeshux
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#280 regressed badly, so refactoring is in order:
Assert network settings nil or non-empty, but do NOT use
preconditionin production (Tunnel is dying prematurely #289)When pulling from server, still fall back to local settings (Local network settings are being ignored #290)
Fix log about local DNS, as local network DNS is only retained when VPN is not default gateway
Remove non-working block-local code
Fixes #289, fixes #290