Adds xml comment documentation #122
Conversation
|
@CodeTherapist I like this. Are you finishing up any changes or should we go ahead and mark this as ready and add more documentation iteratively? |
* Moves types into separeted files but preserve namespace (no breaking change). * Renmes Configuration.cs to Fido2Configration.cs to match type name. * XML docs for IMetadataService as well.
|
I noticed the following things, while documenting:
I would like to be complete and thoroughly as possible. Let me know what I should do with the above mentioned types, properties etc. Any help is as always appreciated. |
CodeTherapist
changed the title
|
Most of the things you could not find are in: The MetadataStatement.Hash is what is described here: https://fidoalliance.org/specs/fido-v2.0-rd-20180702/fido-metadata-service-v2.0-rd-20180702.html#metadata-toc-object-processing-rules, step 6, sub-step 4. It is the computed hash value of the metadata statement that we compare to what we found in the TOC. It is likely that this will be refactored out at some point, this was really included just to get the service functional and passing the conformance tests. Thanks for your help! |
|
@aseigler Thanks for the help. Looks like I was using the previous version of that document - that is why I didn't find all of the properties... 🙄 Even when it's likely to be refactored (the hash property), as long as it's there I will document it. I could add under remarks that this will maybe moved away. Later versions could mark the property as obsolete etc. I will finish this and resolve the conflicts. |
|
Thank you! |
No description provided.