Make TPM attestation format verifier work more like packed with regard to X5C #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
aseigler
commented
Jun 18, 2020
aseigler
commented
- Make U2F, packed, and TPM all use metadata attestation certs the same way (based on Add Microsoft TPM root #166 from @AdamUCF)
- Make validation of root certificates during attestation mandatory if metadata is available for a given authenticator (based on Add optional validation of attestation root certs #164 from @AdamUCF)
- Check all possible attestation roots instead of only the first one
- Update comments to more closely match spec
- Refactor validation steps to more closely match spec
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Closed
Codecov Report
@@ Coverage Diff @@
## master #180 +/- ##
==========================================
+ Coverage 72.18% 72.88% +0.69%
==========================================
Files 68 67 -1
Lines 3387 3142 -245
==========================================
- Hits 2445 2290 -155
+ Misses 942 852 -90
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.