Implement support for apple-appattest attestation format #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #322 +/- ##
==========================================
- Coverage 78.09% 77.92% -0.18%
==========================================
Files 87 88 +1
Lines 2433 2482 +49
Branches 401 412 +11
==========================================
+ Hits 1900 1934 +34
- Misses 431 437 +6
- Partials 102 111 +9 ☔ View full report in Codecov by Sentry. |
gevoulga
reviewed
Sep 12, 2022
|
|
||
| // Verify the validity of the certificates using Apple's App Attest root certificate. | ||
| var chain = new X509Chain(); | ||
| chain.ChainPolicy.RevocationMode = X509RevocationMode.NoCheck; |
There was a problem hiding this comment.
Maybe: NoRevocationCheck when in dev environment?
There was a problem hiding this comment.
In the samples I have seen for both dev and prod there are no CDP extensions present, so no way to check CRL regardless.
gevoulga
reviewed
Sep 12, 2022
gevoulga
reviewed
Sep 12, 2022
gevoulga
reviewed
Sep 12, 2022
jrloe
reviewed
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #319