Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec: auctionReportBuyerDebugModeConfig #118

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

alexmturner
Copy link
Collaborator

@alexmturner alexmturner commented Feb 16, 2024

Specs out the ability to set debug mode details for auctionReportBuyer reporting. See
https://github.com/WICG/turtledove/blob/main/FLEDGE_extended_PA_reporting.md#temporary-debugging-mechanism.


Preview | Diff

@alexmturner
Copy link
Collaborator Author

@qingxinwu, could you PTAL here too? (Formulated this as a separate PR to make this incremental feature more obvious.) Thanks!

cc @caraitto

Copy link

@qingxinwu qingxinwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks good

spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
@alexmturner alexmturner force-pushed the fledge-extensions-auction-buyers-debug-mode branch from b584aad to 383f783 Compare February 22, 2024 21:53
Base automatically changed from fledge-extensions-auction-buyers to main February 22, 2024 22:27
@alexmturner alexmturner force-pushed the fledge-extensions-auction-buyers-debug-mode branch from 1fd8814 to 991efac Compare February 22, 2024 22:28
spec.bs Outdated Show resolved Hide resolved
@alexmturner
Copy link
Collaborator Author

Thanks again!

@alexmturner alexmturner merged commit 4552911 into main Feb 22, 2024
1 check passed
@alexmturner alexmturner deleted the fledge-extensions-auction-buyers-debug-mode branch February 22, 2024 22:51
github-actions bot added a commit that referenced this pull request Feb 22, 2024
SHA: 4552911
Reason: push, by alexmturner

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants