-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spec: auctionReportBuyerDebugModeConfig #118
Merged
alexmturner
merged 3 commits into
main
from
fledge-extensions-auction-buyers-debug-mode
Feb 22, 2024
Merged
Spec: auctionReportBuyerDebugModeConfig #118
alexmturner
merged 3 commits into
main
from
fledge-extensions-auction-buyers-debug-mode
Feb 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@qingxinwu, could you PTAL here too? (Formulated this as a separate PR to make this incremental feature more obvious.) Thanks! cc @caraitto |
qingxinwu
reviewed
Feb 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally looks good
b584aad
to
383f783
Compare
Specs out the ability to set debug mode details for auctionReportBuyer reporting. See https://github.com/WICG/turtledove/blob/main/FLEDGE_extended_PA_reporting.md#temporary-debugging-mechanism.
1fd8814
to
991efac
Compare
qingxinwu
approved these changes
Feb 22, 2024
Thanks again! |
github-actions bot
added a commit
that referenced
this pull request
Feb 22, 2024
SHA: 4552911 Reason: push, by alexmturner Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specs out the ability to set debug mode details for auctionReportBuyer reporting. See
https://github.com/WICG/turtledove/blob/main/FLEDGE_extended_PA_reporting.md#temporary-debugging-mechanism.
Preview | Diff